linux-kernel - Re: [PATCH] ARM: dts: qcom: Add chosen node information for SDX65.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YhfgAL8z6rO+zU3w@builder.lan>
Date:   Thu, 24 Feb 2022 13:44:00 -0600
From:   Bjorn Andersson <bjorn.andersson@...aro.org>
To:     Rohit Agarwal <quic_rohiagar@...cinc.com>
Cc:     agross@...nel.org, robh+dt@...nel.org,
        linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ARM: dts: qcom: Add chosen node information for SDX65.

On Fri 11 Feb 04:20 CST 2022, Rohit Agarwal wrote:

> Add chosen node in the base dtsi file of SDX65.
> 

While this happens to be the same on most boards, it is still a
board-specific decision which UART is the debug uart, or if there is one
at all...

So this property should remain in the dts.

Thanks,
Bjorn

> Signed-off-by: Rohit Agarwal <quic_rohiagar@...cinc.com>
> ---
>  arch/arm/boot/dts/qcom-sdx65-mtp.dts | 4 ----
>  arch/arm/boot/dts/qcom-sdx65.dtsi    | 4 ++++
>  2 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/qcom-sdx65-mtp.dts b/arch/arm/boot/dts/qcom-sdx65-mtp.dts
> index 59457da..3a75c21 100644
> --- a/arch/arm/boot/dts/qcom-sdx65-mtp.dts
> +++ b/arch/arm/boot/dts/qcom-sdx65-mtp.dts
> @@ -14,10 +14,6 @@
>  	aliases {
>  		serial0 = &blsp1_uart3;
>  	};
> -
> -	chosen {
> -		stdout-path = "serial0:115200n8";
> -	};
>  };
>  
>  &blsp1_uart3 {
> diff --git a/arch/arm/boot/dts/qcom-sdx65.dtsi b/arch/arm/boot/dts/qcom-sdx65.dtsi
> index 796641d..653df15 100644
> --- a/arch/arm/boot/dts/qcom-sdx65.dtsi
> +++ b/arch/arm/boot/dts/qcom-sdx65.dtsi
> @@ -17,6 +17,10 @@
>  	qcom,msm-id = <458 0x10000>, <483 0x10000>, <509 0x10000>;
>  	interrupt-parent = <&intc>;
>  
> +	chosen {
> +		stdout-path = "serial0:115200n8";
> +	};
> +
>  	memory {
>  		device_type = "memory";
>  		reg = <0 0>;
> -- 
> 2.7.4
>