linux-kernel - Re: [PATCH 3/3] arm64: dts: qcom: sc7280: Add proxy interconnect requirements for modem

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YhfjqsrHhbU36OqH@builder.lan>
Date:   Thu, 24 Feb 2022 13:59:38 -0600
From:   Bjorn Andersson <bjorn.andersson@...aro.org>
To:     Sibi Sankar <quic_sibis@...cinc.com>
Cc:     robh+dt@...nel.org, ohad@...ery.com, agross@...nel.org,
        mathieu.poirier@...aro.org, linux-arm-msm@...r.kernel.org,
        linux-remoteproc@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, evgreen@...omium.org,
        dianders@...omium.org, swboyd@...omium.org, mka@...omium.org,
        krzysztof.kozlowski@...onical.com
Subject: Re: [PATCH 3/3] arm64: dts: qcom: sc7280: Add proxy interconnect
 requirements for modem

On Sun 13 Feb 22:34 CST 2022, Sibi Sankar wrote:

> Add interconnects that are required to be proxy voted upon during modem
> bootup on SC7280 SoCs.
> 

Looked at this again, and it makes me wonder why do we need to vote on
the path LLCC -> EBI1 and why do we call that path "imem"?

Regards,
Bjorn

> Signed-off-by: Sibi Sankar <quic_sibis@...cinc.com>
> ---
>  arch/arm64/boot/dts/qcom/sc7280-chrome-common.dtsi | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sc7280-chrome-common.dtsi b/arch/arm64/boot/dts/qcom/sc7280-chrome-common.dtsi
> index 9f4a9c263c35..1969f4cf59fe 100644
> --- a/arch/arm64/boot/dts/qcom/sc7280-chrome-common.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc7280-chrome-common.dtsi
> @@ -89,6 +89,8 @@
>  	compatible = "qcom,sc7280-mss-pil";
>  	iommus = <&apps_smmu 0x124 0x0>, <&apps_smmu 0x488 0x7>;
>  	memory-region = <&mba_mem>, <&mpss_mem>;
> +	interconnects = <&mc_virt MASTER_LLCC 0 &mc_virt SLAVE_EBI1 0>;
> +	interconnect-names = "imem";
>  };
>  
>  /* Increase the size from 2.5MB to 8MB */
> -- 
> 2.7.4
>