linux-kernel - [mel:mm-pcpllist-v1r1 15/16] mm/page_alloc.c:3079:16: warning: variable 'flags' set but not used

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <202202250427.rG7MMEJp-lkp@intel.com>
Date:   Fri, 25 Feb 2022 04:51:57 +0800
From:   kernel test robot <lkp@...el.com>
To:     Mel Gorman <mgorman@...e.de>
Cc:     kbuild-all@...ts.01.org, linux-kernel@...r.kernel.org
Subject: [mel:mm-pcpllist-v1r1 15/16] mm/page_alloc.c:3079:16: warning:
 variable 'flags' set but not used

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/mel/linux.git mm-pcpllist-v1r1
head:   b9d96cc9193b170b205c46a39f68b9b35e774a8d
commit: df8f36ca2610d80944adcf40720f6a88aba2b822 [15/16] mm/page_alloc: Demote local_lock_irqsave to local_lock
config: um-i386_defconfig (https://download.01.org/0day-ci/archive/20220225/202202250427.rG7MMEJp-lkp@intel.com/config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build):
        # https://git.kernel.org/pub/scm/linux/kernel/git/mel/linux.git/commit/?id=df8f36ca2610d80944adcf40720f6a88aba2b822
        git remote add mel https://git.kernel.org/pub/scm/linux/kernel/git/mel/linux.git
        git fetch --no-tags mel mm-pcpllist-v1r1
        git checkout df8f36ca2610d80944adcf40720f6a88aba2b822
        # save the config file to linux build tree
        mkdir build_dir
        make W=1 O=build_dir ARCH=um SUBARCH=i386 SHELL=/bin/bash

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

   mm/page_alloc.c: In function 'drain_pages_zone':
>> mm/page_alloc.c:3079:16: warning: variable 'flags' set but not used [-Wunused-but-set-variable]
    3079 |  unsigned long flags;
         |                ^~~~~
   mm/page_alloc.c: In function 'free_unref_page':
   mm/page_alloc.c:3370:16: warning: variable 'flags' set but not used [-Wunused-but-set-variable]
    3370 |  unsigned long flags;
         |                ^~~~~
   mm/page_alloc.c: In function 'free_unref_page_list':
   mm/page_alloc.c:3410:16: warning: variable 'flags' set but not used [-Wunused-but-set-variable]
    3410 |  unsigned long flags;
         |                ^~~~~
   mm/page_alloc.c: In function 'rmqueue_pcplist':
   mm/page_alloc.c:3717:16: warning: variable 'flags' set but not used [-Wunused-but-set-variable]
    3717 |  unsigned long flags;
         |                ^~~~~
   mm/page_alloc.c: At top level:
   mm/page_alloc.c:3854:15: warning: no previous prototype for 'should_fail_alloc_page' [-Wmissing-prototypes]
    3854 | noinline bool should_fail_alloc_page(gfp_t gfp_mask, unsigned int order)
         |               ^~~~~~~~~~~~~~~~~~~~~~
   mm/page_alloc.c: In function '__alloc_pages_bulk':
   mm/page_alloc.c:5245:16: warning: variable 'flags' set but not used [-Wunused-but-set-variable]
    5245 |  unsigned long flags;
         |                ^~~~~


vim +/flags +3079 mm/page_alloc.c

4ae7c03943fca7 Christoph Lameter 2005-06-21  3073  
9f8f2172537de7 Christoph Lameter 2008-02-04  3074  /*
93481ff0e5a0c7 Vlastimil Babka   2014-12-10  3075   * Drain pcplists of the indicated processor and zone.
9f8f2172537de7 Christoph Lameter 2008-02-04  3076   */
93481ff0e5a0c7 Vlastimil Babka   2014-12-10  3077  static void drain_pages_zone(unsigned int cpu, struct zone *zone)
^1da177e4c3f41 Linus Torvalds    2005-04-16  3078  {
c54ad30c784b84 Nicholas Piggin   2006-01-06 @3079  	unsigned long flags;
3dfa5721f12c3d Christoph Lameter 2008-02-04  3080  	struct per_cpu_pages *pcp;
^1da177e4c3f41 Linus Torvalds    2005-04-16  3081  
df8f36ca2610d8 Mel Gorman        2022-02-22  3082  	pcp_local_lock(&pagesets.lock, flags);
^1da177e4c3f41 Linus Torvalds    2005-04-16  3083  
28f836b6777b6f Mel Gorman        2021-06-28  3084  	pcp = per_cpu_ptr(zone->per_cpu_pageset, cpu);
d8d59b4758bcd1 Mel Gorman        2022-02-21  3085  	if (pcp->count) {
d8d59b4758bcd1 Mel Gorman        2022-02-21  3086  		spin_lock(&pcp->lock);
c3d92154d2034c Mel Gorman        2022-02-11  3087  		free_pcppages_bulk(zone, pcp->count, pcp, 0);
d8d59b4758bcd1 Mel Gorman        2022-02-21  3088  		spin_unlock(&pcp->lock);
d8d59b4758bcd1 Mel Gorman        2022-02-21  3089  	}
28f836b6777b6f Mel Gorman        2021-06-28  3090  
df8f36ca2610d8 Mel Gorman        2022-02-22  3091  	pcp_local_unlock(&pagesets.lock, flags);
^1da177e4c3f41 Linus Torvalds    2005-04-16  3092  }
93481ff0e5a0c7 Vlastimil Babka   2014-12-10  3093  

:::::: The code at line 3079 was first introduced by commit
:::::: c54ad30c784b84d0275152d0ca80985b21471811 [PATCH] mm: pagealloc opt

:::::: TO: Nick Piggin <nickpiggin@...oo.com.au>
:::::: CC: Linus Torvalds <torvalds@...osdl.org>

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org