linux-kernel - [hare-scsi-devel:tls-upcall.v2 34/67] crypto/hkdf.c:26:5: warning: no previous prototype for function 'hkdf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Thu, 24 Feb 2022 08:24:58 +0800
From:   kernel test robot <lkp@...el.com>
To:     Hannes Reinecke <hare@...e.de>
Cc:     llvm@...ts.linux.dev, kbuild-all@...ts.01.org,
        linux-kernel@...r.kernel.org
Subject: [hare-scsi-devel:tls-upcall.v2 34/67] crypto/hkdf.c:26:5: warning:
 no previous prototype for function 'hkdf_extract'

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/hare/scsi-devel.git tls-upcall.v2
head:   ac729ea3c52bda460616c71d5f5fc47b2e64da6d
commit: 04ae9ad78a4ea9280f04e5e001fd8a179665d1c1 [34/67] crypto,fs: Separate out hkdf_extract() and hkdf_expand()
config: riscv-buildonly-randconfig-r002-20220223 (https://download.01.org/0day-ci/archive/20220224/202202240845.4HsZOLts-lkp@intel.com/config)
compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project d271fc04d5b97b12e6b797c6067d3c96a8d7470e)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install riscv cross compiling tool for clang build
        # apt-get install binutils-riscv64-linux-gnu
        # https://git.kernel.org/pub/scm/linux/kernel/git/hare/scsi-devel.git/commit/?id=04ae9ad78a4ea9280f04e5e001fd8a179665d1c1
        git remote add hare-scsi-devel https://git.kernel.org/pub/scm/linux/kernel/git/hare/scsi-devel.git
        git fetch --no-tags hare-scsi-devel tls-upcall.v2
        git checkout 04ae9ad78a4ea9280f04e5e001fd8a179665d1c1
        # save the config file to linux build tree
        mkdir build_dir
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=riscv SHELL=/bin/bash

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

>> crypto/hkdf.c:26:5: warning: no previous prototype for function 'hkdf_extract' [-Wmissing-prototypes]
   int hkdf_extract(struct crypto_shash *hmac_tfm, const u8 *ikm,
       ^
   crypto/hkdf.c:26:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
   int hkdf_extract(struct crypto_shash *hmac_tfm, const u8 *ikm,
   ^
   static 
   crypto/hkdf.c:57:5: warning: unused variable 'prefix' [-Wunused-variable]
           u8 prefix[9];
              ^
>> crypto/hkdf.c:52:5: warning: no previous prototype for function 'hkdf_expand' [-Wmissing-prototypes]
   int hkdf_expand(struct crypto_shash *hmac_tfm,
       ^
   crypto/hkdf.c:52:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
   int hkdf_expand(struct crypto_shash *hmac_tfm,
   ^
   static 
   3 warnings generated.


vim +/hkdf_extract +26 crypto/hkdf.c

    14	
    15	/*
    16	 * HKDF consists of two steps:
    17	 *
    18	 * 1. HKDF-Extract: extract a pseudorandom key of length HKDF_HASHLEN bytes from
    19	 *    the input keying material and optional salt.
    20	 * 2. HKDF-Expand: expand the pseudorandom key into output keying material of
    21	 *    any length, parameterized by an application-specific info string.
    22	 *
    23	 */
    24	
    25	/* HKDF-Extract (RFC 5869 section 2.2), unsalted */
  > 26	int hkdf_extract(struct crypto_shash *hmac_tfm, const u8 *ikm,
    27			 unsigned int ikmlen, u8 *prk)
    28	{
    29		unsigned int prklen = crypto_shash_digestsize(hmac_tfm);
    30		u8 *default_salt;
    31		int err;
    32	
    33		default_salt = kzalloc(prklen, GFP_KERNEL);
    34		if (!default_salt)
    35			return -ENOMEM;
    36		err = crypto_shash_setkey(hmac_tfm, default_salt, prklen);
    37		if (!err)
    38			err = crypto_shash_tfm_digest(hmac_tfm, ikm, ikmlen, prk);
    39	
    40		kfree(default_salt);
    41		return err;
    42	}
    43	EXPORT_SYMBOL_GPL(hkdf_extract);
    44	
    45	/*
    46	 * HKDF-Expand (RFC 5869 section 2.3).
    47	 * This expands the pseudorandom key, which was already keyed into @hmac_tfm,
    48	 * into @okmlen bytes of output keying material parameterized by the
    49	 * application-specific @info of length @infolen bytes.
    50	 * This is thread-safe and may be called by multiple threads in parallel.
    51	 */
  > 52	int hkdf_expand(struct crypto_shash *hmac_tfm,

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org