linux-kernel - Re: [LSF/MM/BPF TOPIC] Enabling change notification for network and cluster fs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Yhf+FemcQQToB5x+@redhat.com>
Date:   Thu, 24 Feb 2022 16:52:21 -0500
From:   Vivek Goyal <vgoyal@...hat.com>
To:     Steve French <smfrench@...il.com>
Cc:     lsf-pc@...ts.linux-foundation.org,
        linux-fsdevel <linux-fsdevel@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Ioannis Angelakopoulos <jaggel@...edu>
Subject: Re: [LSF/MM/BPF TOPIC] Enabling change notification for network and
 cluster fs

On Wed, Feb 23, 2022 at 11:16:33PM -0600, Steve French wrote:
> Currently only local events can be waited on with the current notify
> kernel API since the requests to wait on these events is not passed to
> the filesystem.   Especially for network and cluster filesystems it is
> important that they be told that applications want to be notified of
> these file or directory change events.
> 
> A few years ago, discussions began on the changes needed to enable
> support for this.   Would be timely to finish those discussions, as
> waiting on file and directory change events to network mounts is very
> common for other OS, and would be valuable for Linux to fix.
> 

This sounds like which might have some overlap with what we are trying
to do.

Currently inotify/fanotify only work for local filesystems. We were
thinking is it possible to extend it for remote filesystems as well. My
interest primarily was to make notifications work on virtiofs. So I
asked Ioannis (an intern with us) to try to prototype it and see what are
the challenges and roadblocks.

He posted one version of patches just as proof of concept and only tried
to make remote inotify work. One primary feedback from Amir was that
this is too specific to inotify and if you are extending fsnotify, then
it should have some support for fanotify as well. There is bunch of
other feedback too. So Ioannis is trying to rework his patches now.

https://lore.kernel.org/linux-fsdevel/20211025204634.2517-1-iangelak@redhat.com/

Anyway, you had pointed to following commit.

https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/fs/cifs/ioctl.c?id=d26c2ddd33569667e3eeb577c4c1d966ca9192e2

So looks like application calls this cifs specific ioctl and blocks and
unblocks when notifications comes, IIUC.

I don't know about SMB and what kind of other notifications does it
support. With this proposal, you are trying to move away from cifs
specific ioctl? What will user use to either block or poll for the
said notification.

Sorry, I might be just completely off the mark. Just trying to find out
if there is any overlap in what you are looking for and what we are
trying to do. 

Thanks
Vivek

> -- 
> Thanks,
> 
> Steve
>