linux-kernel - Re: [netfilter-nf:master 47/47] nf_queue.c:undefined reference to `sock_gen

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220224221728.GI28705@breakpoint.cc>
Date:   Thu, 24 Feb 2022 23:17:28 +0100
From:   Florian Westphal <fw@...len.de>
To:     netfilter-devel <netfilter-devel@...r.kernel.org>
Cc:     Florian Westphal <fw@...len.de>, kbuild-all@...ts.01.org,
        linux-kernel@...r.kernel.org,
        Pablo Neira Ayuso <pablo@...filter.org>
Subject: Re: [netfilter-nf:master 47/47] nf_queue.c:undefined reference to
 `sock_gen_put'

kernel test robot <lkp@...el.com> wrote:

[ cc nf-devel ]

> tree:   git://git.kernel.org/pub/scm/linux/kernel/git/netfilter/nf.git master
> head:   661c8ec0381915e9a2b0f9dcc03a5bd70ba5e3dd
> commit: 661c8ec0381915e9a2b0f9dcc03a5bd70ba5e3dd [47/47] netfilter: nf_queue: don't assume sk is full socket
> config: arm-randconfig-c002-20220223 (https://download.01.org/0day-ci/archive/20220225/202202250551.bHhoyNSe-lkp@intel.com/config)
> compiler: arm-linux-gnueabi-gcc (GCC) 11.2.0
> reproduce (this is a W=1 build):
>         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         # https://git.kernel.org/pub/scm/linux/kernel/git/netfilter/nf.git/commit/?id=661c8ec0381915e9a2b0f9dcc03a5bd70ba5e3dd
>         git remote add netfilter-nf git://git.kernel.org/pub/scm/linux/kernel/git/netfilter/nf.git
>         git fetch --no-tags netfilter-nf master
>         git checkout 661c8ec0381915e9a2b0f9dcc03a5bd70ba5e3dd
>         # save the config file to linux build tree
>         mkdir build_dir
>         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=arm SHELL=/bin/bash
> 
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@...el.com>
> 
> All errors (new ones prefixed by >>):
> 
>    arm-linux-gnueabi-ld: net/netfilter/nf_queue.o: in function `nf_queue_entry_release_refs':
> >> nf_queue.c:(.text+0x60): undefined reference to `sock_gen_put'

CONFIG_NETFILTER=y
CONFIG_DECNET=y
CONFIG_INET=n

I could add ugly ifdef to use sock_put() like before for !INET case.
OTOH, the entire nfqueue infra is doubtful in this config.

Maybe elide that completely?  Any advice/preferred solution?