linux-kernel - Re: [PATCH v2 1/6] dt-bindings: input: touchscreen: edt-ft5x06: add report-rate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 24 Feb 2022 16:27:51 -0600
From:   Rob Herring <robh@...nel.org>
To:     Dario Binacchi <dario.binacchi@...rulasolutions.com>
Cc:     linux-kernel@...r.kernel.org,
        Michael Trimarchi <michael@...rulasolutions.com>,
        Dmitry Torokhov <dmitry.torokhov@...il.com>,
        Stephan Gerhold <stephan@...hold.net>,
        devicetree@...r.kernel.org, linux-input@...r.kernel.org
Subject: Re: [PATCH v2 1/6] dt-bindings: input: touchscreen: edt-ft5x06: add
 report-rate

On Thu, Feb 17, 2022 at 05:55:53PM +0100, Dario Binacchi wrote:
> It allows to change the M06/M12 default scan rate.
> 
> Co-developed-by: Michael Trimarchi <michael@...rulasolutions.com>
> Signed-off-by: Michael Trimarchi <michael@...rulasolutions.com>
> Signed-off-by: Dario Binacchi <dario.binacchi@...rulasolutions.com>
> ---
> 
> (no changes since v1)
> 
>  .../devicetree/bindings/input/touchscreen/edt-ft5x06.yaml | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.yaml b/Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.yaml
> index 2e8da7470513..aa8517c6f65b 100644
> --- a/Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.yaml
> +++ b/Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.yaml
> @@ -85,6 +85,14 @@ properties:
>      minimum: 0
>      maximum: 80
>  
> +  report-rate:

Use property unit suffix: report-rate-hz

This should probably be moved to touchscreen.yaml as it seems common.

> +    description: Allows setting the scan rate.
> +                 M06 supports range from 3 (30 Hz) to 14 (140 Hz).

You're using 3 or 30 in this case? Should be 30, but it's not clear. I'd 
just list the range in Hz and leave the conversion detail to the driver.

> +                 M12 supports range from 1 (1 Hz) to 255 (255 Hz).

Use '|' if formatting (newline) is significant.

> +    $ref: /schemas/types.yaml#/definitions/uint32
> +    minimum: 1
> +    maximum: 255
> +
>    touchscreen-size-x: true
>    touchscreen-size-y: true
>    touchscreen-fuzz-x: true
> -- 
> 2.32.0
> 
>