linux-kernel - Re: [PATCHv4 18/30] x86/tdx: Handle early boot port I/O

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fe1dd1df-5979-04fe-269e-48bcd5edeaee@intel.com>
Date:   Thu, 24 Feb 2022 14:58:27 -0800
From:   Dave Hansen <dave.hansen@...el.com>
To:     "Kirill A. Shutemov" <kirill.shutemov@...ux.intel.com>,
        tglx@...utronix.de, mingo@...hat.com, bp@...en8.de,
        luto@...nel.org, peterz@...radead.org
Cc:     sathyanarayanan.kuppuswamy@...ux.intel.com, aarcange@...hat.com,
        ak@...ux.intel.com, dan.j.williams@...el.com, david@...hat.com,
        hpa@...or.com, jgross@...e.com, jmattson@...gle.com,
        joro@...tes.org, jpoimboe@...hat.com, knsathya@...nel.org,
        pbonzini@...hat.com, sdeep@...are.com, seanjc@...gle.com,
        tony.luck@...el.com, vkuznets@...hat.com, wanpengli@...cent.com,
        thomas.lendacky@....com, brijesh.singh@....com, x86@...nel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCHv4 18/30] x86/tdx: Handle early boot port I/O

I wish this was telling more of a story.  There *is* a story to be told
and this series is really missing an opportunity to tell it.  The last
three patches do the same logical thing: add support for I/O
instructions when running as a TDX guest.  But, the three subjects call
it: "Support", "Add" and "Handle".  All three talk about "port I/O", but
in different ways.

Imagine you had the subjects be:

	x86/boot: Port I/O: add decompression-time support for TDX
	x86/tdx: Port I/O: add runtime hypercalls
	x86/tdx: Port I/O: add early boot support

That makes it be visually *obvious* what's going on.  All three are
covering the same ground: "Port I/O".  They're all adding something.  In
succession they add the same basic thing for
{decompression,runtime,early} code.

I mentioned this exact thing to *somebody* about this exact part of the
series, who knows when.  But, it still bugs me...

On 2/24/22 07:56, Kirill A. Shutemov wrote:
> From: Andi Kleen <ak@...ux.intel.com>
> 
> TDX guests cannot do port I/O directly. The TDX module triggers a #VE
> exception to let the guest kernel emulate port I/O by converting them
> into TDCALLs to call the host.

As part of telling the story, it would be best to refer to the code that
you introduced in the last few patches.  "At runtime..." could hearken
back to the subject from two patches ago.

Anyway, the code is fine.

Acked-by: Dave Hansen <dave.hansen@...ux.intel.com>