linux-kernel - Re: [PATCH][next] staging: r8188eu: remove redundant variable reg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YhgSFC0VDvdfsryB@equinox>
Date:   Thu, 24 Feb 2022 23:17:40 +0000
From:   Phillip Potter <phil@...lpotter.co.uk>
To:     Colin Ian King <colin.i.king@...il.com>
Cc:     Larry Finger <Larry.Finger@...inger.net>,
        Phillip Potter <phil@...lpotter.co.uk>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Michael Straube <straube.linux@...il.com>,
        linux-staging@...ts.linux.dev, kernel-janitors@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH][next] staging: r8188eu: remove redundant variable
 reg_0x143

On Thu, Feb 24, 2022 at 11:06:58PM +0000, Colin Ian King wrote:
> Variable reg_0x143 is being assigned a value, however is not being
> read. The variable is redundant and can be removed.
> 
> Signed-off-by: Colin Ian King <colin.i.king@...il.com>
> ---
>  drivers/staging/r8188eu/hal/rtl8188e_hal_init.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/r8188eu/hal/rtl8188e_hal_init.c b/drivers/staging/r8188eu/hal/rtl8188e_hal_init.c
> index cf58dfc3ff4d..53ebea311723 100644
> --- a/drivers/staging/r8188eu/hal/rtl8188e_hal_init.c
> +++ b/drivers/staging/r8188eu/hal/rtl8188e_hal_init.c
> @@ -189,7 +189,6 @@ static void efuse_read_phymap_from_txpktbuf(
>  {
>  	u16 dbg_addr = 0;
>  	u32 start  = 0, passing_time = 0;
> -	u8 reg_0x143 = 0;
>  	__le32 lo32 = 0, hi32 = 0;
>  	u16 len = 0, count = 0;
>  	int i = 0;
> @@ -209,7 +208,7 @@ static void efuse_read_phymap_from_txpktbuf(
>  
>  		rtw_write8(adapter, REG_TXPKTBUF_DBG, 0);
>  		start = jiffies;
> -		while (!(reg_0x143 = rtw_read8(adapter, REG_TXPKTBUF_DBG)) &&
> +		while (!rtw_read8(adapter, REG_TXPKTBUF_DBG) &&
>  		       (passing_time = rtw_get_passing_time_ms(start)) < 1000)
>  			rtw_usleep_os(100);
>  
> -- 
> 2.34.1
> 

Looks good to me, thanks Colin.

Reviewed-by: Phillip Potter <phil@...lpotter.co.uk>

Regards,
Phil