linux-kernel - RE: [PATCH net-next v2 0/4] net/mlx5: Introduce devlink param to disable SF aux dev probe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <PH0PR12MB5481DCB01F443BFC559430C4DC3D9@PH0PR12MB5481.namprd12.prod.outlook.com>
Date:   Thu, 24 Feb 2022 03:44:20 +0000
From:   Parav Pandit <parav@...dia.com>
To:     Jakub Kicinski <kuba@...nel.org>, Moshe Shemesh <moshe@...dia.com>
CC:     "David S. Miller" <davem@...emloft.net>,
        Jiri Pirko <jiri@...dia.com>,
        Saeed Mahameed <saeedm@...dia.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH net-next v2 0/4] net/mlx5: Introduce devlink param to
 disable SF aux dev probe

Hi Jakub,

> From: Parav Pandit
> Sent: Monday, February 14, 2022 8:16 PM
> 
> > From: Jakub Kicinski <kuba@...nel.org>
> > Sent: Saturday, February 12, 2022 6:43 AM
> >
> > On Fri, 11 Feb 2022 11:20:17 +0200 Moshe Shemesh wrote:
> > > v1->v2:
> > >  - updated example to make clear SF port and SF device creation PFs
> > >  - added example when SF port and device creation PFs are on
> > > different hosts
> >
> > How does this address my comments?
> >
> Which one?
> Your suggestion in [1] to specify vnet during port function spawning time?
> Or
> Your suggestion in [2] to add "noprobe" option?

> Saeed is offline this week, and I want to gather his feedback as well on passing
> hints from port spawning side to host side.

Saeed is back. Saeed, others and I discussed the per SF knob further.
The option to indicate to not initialize the SF device during port spawning time is very useful to users.

So, how about crafting below UAPI?
Example:

Esw side:
$ devlink port add <dev> flavour pcisf .. 
$ devlink port function set <port> hw_addr 00:11:22:33:44:55 initialize false/true ...

The "initialize" option indicates whether a function should fully initialize or not at driver level on the host side.
When initialize=false, the device will spawn but not initialize until a user on the host initialize it using the existing devlink reload API on this SF device.

For example, on host side, a user will be able to do,
$ devlink dev auxiliary/mlx5_core.sf2 resource/param set
$ devlink dev reload auxiliary/mlx5_core.sf.2