linux-kernel - [RFC V5 11/16] blk/rq-qos: get rid of debugfs register in blk_mq_debugfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20220224090654.54671-12-jianchao.wan9@gmail.com>
Date:   Thu, 24 Feb 2022 17:06:49 +0800
From:   "Wang Jianchao (Kuaishou)" <jianchao.wan9@...il.com>
To:     Jens Axboe <axboe@...nel.dk>
Cc:     Josef Bacik <jbacik@...com>, Tejun Heo <tj@...nel.org>,
        Bart Van Assche <bvanassche@....org>,
        linux-block@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: [RFC V5 11/16] blk/rq-qos: get rid of debugfs register in blk_mq_debugfs_register

There is not any enabled rqos policy when queue is initialized,
get rid of the coding for registering debugfs.

Signed-off-by: Wang Jianchao (Kuaishou) <jianchao.wan9@...il.com>
---
 block/blk-mq-debugfs.c | 12 ------------
 1 file changed, 12 deletions(-)

diff --git a/block/blk-mq-debugfs.c b/block/blk-mq-debugfs.c
index 7e3c3cc1b1a9..4c9dafd16a08 100644
--- a/block/blk-mq-debugfs.c
+++ b/block/blk-mq-debugfs.c
@@ -726,18 +726,6 @@ void blk_mq_debugfs_register(struct request_queue *q)
 		if (q->elevator && !hctx->sched_debugfs_dir)
 			blk_mq_debugfs_register_sched_hctx(q, hctx);
 	}
-
-	if (q->rq_qos) {
-		struct rq_qos *rqos = q->rq_qos;
-		/*
-		 * Queue has not been registered right now, it is safe to
-		 * iterate the rqos w/o lock
-		 */
-		while (rqos) {
-			blk_mq_debugfs_register_rqos(rqos);
-			rqos = rqos->next;
-		}
-	}
 }
 
 void blk_mq_debugfs_unregister(struct request_queue *q)
-- 
2.17.1