linux-kernel - Re: [PATCH] power: supply: max14656: Use devm_work

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220224112332.2ex4jah4javrufgh@mercury.elektranox.org>
Date:   Thu, 24 Feb 2022 12:23:32 +0100
From:   Sebastian Reichel <sebastian.reichel@...labora.com>
To:     Christophe JAILLET <christophe.jaillet@...adoo.fr>
Cc:     linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org,
        linux-pm@...r.kernel.org
Subject: Re: [PATCH] power: supply: max14656: Use devm_work_autocancel()

Hi,

On Sun, Feb 13, 2022 at 12:54:56PM +0100, Christophe JAILLET wrote:
> Use devm_delayed_work_autocancel() instead of hand writing it.
> It saves a few lines of code.
> 
> Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>
> ---

Thanks, queued.

-- Sebastian

>  drivers/power/supply/max14656_charger_detector.c | 15 ++++-----------
>  1 file changed, 4 insertions(+), 11 deletions(-)
> 
> diff --git a/drivers/power/supply/max14656_charger_detector.c b/drivers/power/supply/max14656_charger_detector.c
> index 3f49b29f3c88..fc36828895bf 100644
> --- a/drivers/power/supply/max14656_charger_detector.c
> +++ b/drivers/power/supply/max14656_charger_detector.c
> @@ -18,6 +18,7 @@
>  #include <linux/of_device.h>
>  #include <linux/workqueue.h>
>  #include <linux/power_supply.h>
> +#include <linux/devm-helpers.h>
>  
>  #define MAX14656_MANUFACTURER	"Maxim Integrated"
>  #define MAX14656_NAME		"max14656"
> @@ -233,14 +234,6 @@ static enum power_supply_property max14656_battery_props[] = {
>  	POWER_SUPPLY_PROP_MANUFACTURER,
>  };
>  
> -static void stop_irq_work(void *data)
> -{
> -	struct max14656_chip *chip = data;
> -
> -	cancel_delayed_work_sync(&chip->irq_work);
> -}
> -
> -
>  static int max14656_probe(struct i2c_client *client,
>  			  const struct i2c_device_id *id)
>  {
> @@ -286,10 +279,10 @@ static int max14656_probe(struct i2c_client *client,
>  		return -EINVAL;
>  	}
>  
> -	INIT_DELAYED_WORK(&chip->irq_work, max14656_irq_worker);
> -	ret = devm_add_action(dev, stop_irq_work, chip);
> +	ret = devm_delayed_work_autocancel(dev, &chip->irq_work,
> +					   max14656_irq_worker);
>  	if (ret) {
> -		dev_err(dev, "devm_add_action %d failed\n", ret);
> +		dev_err(dev, "devm_delayed_work_autocancel %d failed\n", ret);
>  		return ret;
>  	}
>  
> -- 
> 2.32.0
> 

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)