linux-kernel - Re: [PATCH] dt-bindings: spi: delete unused required and adjust the item.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 24 Feb 2022 07:36:15 -0600
From:   Rob Herring <robh+dt@...nel.org>
To:     Li-hao Kuo <lhjeff911@...il.com>
Cc:     Mark Brown <broonie@...nel.org>,
        linux-spi <linux-spi@...r.kernel.org>,
        devicetree@...r.kernel.org,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Wells Lu 呂芳騰 <wells.lu@...plus.com>,
        "LH.Kuo" <lh.kuo@...plus.com>
Subject: Re: [PATCH] dt-bindings: spi: delete unused required and adjust the item.

On Thu, Feb 17, 2022 at 7:56 PM Li-hao Kuo <lhjeff911@...il.com> wrote:
>
> delete unused required(clock-name)
> adjust position (interrupts)

Why? This seems like an unnecessary change.

Please write complete sentences that answer why this change is needed,
not what the change is. The diff describes what changed. In this case,
quoting the warning you are fixing is typical.

>
> Fixes: 3b8ab4da34 ("spi: Fix test error for sp7021")
>

There should not be a blank line here.

> Reported-by: Rob Herring <robh+dt@...nel.org>
> Signed-off-by: Li-hao Kuo <lhjeff911@...il.com>
> ---
>  Documentation/devicetree/bindings/spi/spi-sunplus-sp7021.yaml | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/spi/spi-sunplus-sp7021.yaml b/Documentation/devicetree/bindings/spi/spi-sunplus-sp7021.yaml
> index 298eac2..9df08d7 100644
> --- a/Documentation/devicetree/bindings/spi/spi-sunplus-sp7021.yaml
> +++ b/Documentation/devicetree/bindings/spi/spi-sunplus-sp7021.yaml
> @@ -47,10 +47,9 @@ required:
>    - compatible
>    - reg
>    - reg-names
> -  - interrupts
>    - interrupt-names
> +  - interrupts
>    - clocks
> -  - clocks-names
>    - resets
>    - pinctrl-names
>    - pinctrl-0
> --
> 2.7.4
>