linux-kernel - [PATCH] genirq: add log level to printk in print_irq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <20220224144018.2271-1-wudaemon@163.com>
Date:   Thu, 24 Feb 2022 14:40:18 +0000
From:   wudaemon <wudaemon@....com>
To:     tglx@...utronix.de
Cc:     linux-kernel@...r.kernel.org, wudaemon <wudaemon@....com>
Subject: [PATCH] genirq: add log level to printk in print_irq_desc

add KERN_DEBUG level for debuging purpose, use checkpatch.pl check prompt:
ERROR: Macros starting with if should be enclosed by a do - while loop to avoid possible if/else logic defects
so add do - while loop to Macros
Signed-off-by: wudaemon <wudaemon@....com>
---
 kernel/irq/debug.h | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/kernel/irq/debug.h b/kernel/irq/debug.h
index 8ccb326d2977..ce0ec677bea0 100644
--- a/kernel/irq/debug.h
+++ b/kernel/irq/debug.h
@@ -3,8 +3,8 @@
  * Debugging printout:
  */
 
-#define ___P(f) if (desc->status_use_accessors & f) printk("%14s set\n", #f)
-#define ___PS(f) if (desc->istate & f) printk("%14s set\n", #f)
+#define ___P(f) do {if (desc->status_use_accessors & f) printk(KERN_DEBUG "%14s set\n", #f); } while (0)
+#define ___PS(f) do {if (desc->istate & f) printk(KERN_DEBUG "%14s set\n", #f); } while (0)
 /* FIXME */
 #define ___PD(f) do { } while (0)
 
@@ -15,15 +15,15 @@ static inline void print_irq_desc(unsigned int irq, struct irq_desc *desc)
 	if (!__ratelimit(&ratelimit))
 		return;
 
-	printk("irq %d, desc: %p, depth: %d, count: %d, unhandled: %d\n",
+	printk(KERN_DEBUG "irq %d, desc: %p, depth: %d, count: %d, unhandled: %d\n",
 		irq, desc, desc->depth, desc->irq_count, desc->irqs_unhandled);
-	printk("->handle_irq():  %p, %pS\n",
+	printk(KERN_DEBUG "->handle_irq():  %p, %pS\n",
 		desc->handle_irq, desc->handle_irq);
-	printk("->irq_data.chip(): %p, %pS\n",
+	printk(KERN_DEBUG "->irq_data.chip(): %p, %pS\n",
 		desc->irq_data.chip, desc->irq_data.chip);
-	printk("->action(): %p\n", desc->action);
+	printk(KERN_DEBUG "->action(): %p\n", desc->action);
 	if (desc->action) {
-		printk("->action->handler(): %p, %pS\n",
+		printk(KERN_DEBUG "->action->handler(): %p, %pS\n",
 			desc->action->handler, desc->action->handler);
 	}
 
-- 
2.25.1