linux-kernel - Re: [PATCH] ACPI: bus: Match first 9 bytes of device IDs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YhkO+wXED5IXlCMv@zx2c4.com>
Date:   Fri, 25 Feb 2022 18:16:43 +0100
From:   "Jason A. Donenfeld" <Jason@...c4.com>
To:     Alexander Graf <graf@...zon.com>
Cc:     linux-acpi@...r.kernel.org, linux-kernel@...r.kernel.org,
        Len Brown <lenb@...nel.org>,
        "Rafael J. Wysocki" <rafael@...nel.org>,
        Greg KH <gregkh@...uxfoundation.org>, ardb@...nel.org,
        dwmw@...zon.co.uk
Subject: Re: [PATCH] ACPI: bus: Match first 9 bytes of device IDs

Hi Alex,

On Fri, Feb 25, 2022 at 06:09:59PM +0100, Alexander Graf wrote:
> You have to make this "VM_GEN_CO". I now match the full 9 bytes - unlike 
> the previous patch I sent :)

Ahh, so no NULL byte, but presumably no need because strncmp is used.
Great, seems to work.

There's the other aspect of udev matching, by the way. Have you tested
what happens in userspace? Need be, we could make the vmgenid driver a
bool instead of a tristate, but maybe there's a way to do that right?

Jason