linux-kernel - Re: [PATCHv3 03/10] asm-generic: introduce be48 unaligned accessors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220225175903.GC4111669@dhcp-10-100-145-180.wdc.com>
Date:   Fri, 25 Feb 2022 09:59:03 -0800
From:   Keith Busch <kbusch@...nel.org>
To:     Joe Perches <joe@...ches.com>
Cc:     Christoph Hellwig <hch@....de>, linux-nvme@...ts.infradead.org,
        linux-block@...r.kernel.org, linux-crypto@...r.kernel.org,
        x86@...nel.org, linux-kernel@...r.kernel.org, axboe@...nel.dk,
        martin.petersen@...cle.com, colyli@...e.de,
        Hannes Reinecke <hare@...e.de>, Arnd Bergmann <arnd@...db.de>
Subject: Re: [PATCHv3 03/10] asm-generic: introduce be48 unaligned accessors

On Fri, Feb 25, 2022 at 09:53:11AM -0800, Joe Perches wrote:
> On Fri, 2022-02-25 at 17:03 +0100, Christoph Hellwig wrote:
> > On Tue, Feb 22, 2022 at 08:31:37AM -0800, Keith Busch wrote:
> > > The NVMe protocol extended the data integrity fields with unaligned
> > > 48-bit reference tags. Provide some helper accessors in
> > > preparation for these.
> > > 
> > > Reviewed-by: Hannes Reinecke <hare@...e.de>
> > > Reviewed-by: Martin K. Petersen <martin.petersen@...cle.com>
> > > Acked-by: Arnd Bergmann <arnd@...db.de>
> > > Signed-off-by: Keith Busch <kbusch@...nel.org>
> > 
> > Looks good,
> > 
> > Reviewed-by: Christoph Hellwig <hch@....de>
> 
> Perhaps for completeness this should also add the le48 variants
> like the 24 bit accessors above this.

I don't know of a user for le48 at this time, and kernel API's without
users often get culled. If you think it's useful, though, I can
certainly include it.