linux-kernel - Re: [PATCH v2 00/39] x86: Kernel IBT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220225201523.tuc2pb4bhuichey3@treble>
Date:   Fri, 25 Feb 2022 12:15:23 -0800
From:   Josh Poimboeuf <jpoimboe@...hat.com>
To:     Peter Zijlstra <peterz@...radead.org>
Cc:     Steven Rostedt <rostedt@...dmis.org>, x86@...nel.org,
        joao@...rdrivepizza.com, hjl.tools@...il.com,
        andrew.cooper3@...rix.com, linux-kernel@...r.kernel.org,
        ndesaulniers@...gle.com, keescook@...omium.org,
        samitolvanen@...gle.com, mark.rutland@....com,
        alyssa.milburn@...el.com, mbenes@...e.cz, mhiramat@...nel.org,
        alexei.starovoitov@...il.com
Subject: Re: [PATCH v2 00/39] x86: Kernel IBT

On Fri, Feb 25, 2022 at 08:53:03PM +0100, Peter Zijlstra wrote:
> On Fri, Feb 25, 2022 at 12:32:38PM -0500, Steven Rostedt wrote:
> > On Fri, 25 Feb 2022 09:26:44 -0800
> > Josh Poimboeuf <jpoimboe@...hat.com> wrote:
> > 
> > > > Damn, I just realized this makes KERNEL_IBT hard depend on KALLSYMS :-(  
> > > 
> > > Why should the jump label patching code even care whether there's an
> > > ENDBR at the jump target?  It should never jump to the beginning of a
> > > function anyway, right?  And objtool presumably doesn't patch out ENDBRs
> > > in the middle of a function.
> > 
> > Perhaps Peter confused jump labels with static calls?
> 
> The code is shared between the two.

Then just have a text_gen_insn_dont_skip_endbr() or so... ?

-- 
Josh