linux-kernel - Re: [PATCH v2] tracefs: Set the group ownership in apply_options() not parse

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220225153232.26e0b335@gandalf.local.home>
Date:   Fri, 25 Feb 2022 15:32:32 -0500
From:   Steven Rostedt <rostedt@...dmis.org>
To:     LKML <linux-kernel@...r.kernel.org>
Cc:     Al Viro <viro@...IV.linux.org.uk>
Subject: Re: [PATCH v2] tracefs: Set the group ownership in apply_options()
 not parse_options()

On Fri, 25 Feb 2022 15:21:23 -0500
Steven Rostedt <rostedt@...dmis.org> wrote:

> From: "Steven Rostedt (Google)" <rostedt@...dmis.org>
> 
> Al Viro brought it to my attention that the dentries may not be filled
> when the parse_options() is called, causing the call to set_gid() to
> possibly crash. It should only be called if parse_options() succeeds
> totally anyway.
> 
> He suggested the logical place to do the update is in apply_options().
> 
> Link: https://lore.kernel.org/all/20220225165219.737025658@goodmis.org/
> 
> Cc: stable@...r.kernel.org
> Reported-by: Al Viro <viro@...iv.linux.org.uk>
> Fixes: 48b27b6b5191 ("tracefs: Set all files to the same group ownership as the mount option")
> Signed-off-by: Steven Rostedt (Google) <rostedt@...dmis.org>
> ---
>  fs/tracefs/inode.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/fs/tracefs/inode.c b/fs/tracefs/inode.c
> index bafc02bf8220..3638d330ff5a 100644
> --- a/fs/tracefs/inode.c
> +++ b/fs/tracefs/inode.c
> @@ -264,7 +264,6 @@ static int tracefs_parse_options(char *data, struct tracefs_mount_opts *opts)
>  			if (!gid_valid(gid))
>  				return -EINVAL;
>  			opts->gid = gid;
> -			set_gid(tracefs_mount->mnt_root, gid);
>  			break;
>  		case Opt_mode:
>  			if (match_octal(&args[0], &option))
> @@ -293,6 +292,9 @@ static int tracefs_apply_options(struct super_block *sb)
>  	inode->i_uid = opts->uid;
>  	inode->i_gid = opts->gid;
>  
> +	if (tracefs_mount && tracefs_mount->mnt_root)
> +		set_gid(tracefs_mount->mnt_root, opts->gid);

Bah, I forgot the '-a' in 'git commit -a --amend'

Ignore this :-/

-- Steve

> +
>  	return 0;
>  }
>