linux-kernel - Re: [PATCH] Documentation/vm/page_owner.rst: fix the description of "-f"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <73c74276-3c29-e662-cb96-c09fbba0d2b1@linuxfoundation.org>
Date:   Fri, 25 Feb 2022 14:45:13 -0700
From:   Shuah Khan <skhan@...uxfoundation.org>
To:     Yixuan Cao <caoyixuan2019@...il.szu.edu.cn>, corbet@....net
Cc:     akpm@...ux-foundation.org, broonie@...nel.org,
        weizhenliang@...wei.com, georgi.djakov@...aro.org,
        linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org,
        hanshenghong2019@...il.szu.edu.cn,
        Shuah Khan <skhan@...uxfoundation.org>
Subject: Re: [PATCH] Documentation/vm/page_owner.rst: fix the description of
 "-f"

On 2/25/22 2:08 AM, Yixuan Cao wrote:
> Few days ago,
> I noticed that in tools/vm/page_owner_sort.c,
> there is a comment that need to be fixed.
> 
> In function usage():
> "-f Filter out the information of blocks whose memory has
> not been released."
> 
> This comment does not match the actual function, the "not"
> should be removed. As a result, I submitted a patch to fix it.
> 
> Similarly, this document should also do the same
> modification, that's why I submit this patch.
> 

Please refer to a few change logs to write them so maintainers
don't have to fix them. This can be written as:

"Fix function usage information for -f option"

> Signed-off-by: Yixuan Cao <caoyixuan2019@...il.szu.edu.cn>
> ---
>   Documentation/vm/page_owner.rst | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/vm/page_owner.rst b/Documentation/vm/page_owner.rst
> index aec1906976f4..32ca54757d3f 100644
> --- a/Documentation/vm/page_owner.rst
> +++ b/Documentation/vm/page_owner.rst
> @@ -78,7 +78,7 @@ Usage
>   
>   2) Enable page owner: add "page_owner=on" to boot cmdline.
>   
> -3) Do the job what you want to debug
> +3) Do the job what you want to debug.
>   
>   4) Analyze information from page owner::
>   
> @@ -126,4 +126,4 @@ Usage
>   		-c		Cull by comparing stacktrace instead of total block.
>   
>   	Filter:
> -		-f		Filter out the information of blocks whose memory has not been released.
> +		-f		Filter out the information of blocks whose memory has been released.
> 

I can't find this in Linux 5.17-rc5 - is this patch based on linux-next?

thanks,
-- Shuah