linux-kernel - Re: [PATCH v4 2/3] sysfb: Enable boot time VESA graphic mode selection

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ae441f09-3d63-a731-fe59-06b8aafa0983@redhat.com>
Date:   Fri, 25 Feb 2022 23:10:51 +0100
From:   Javier Martinez Canillas <javierm@...hat.com>
To:     Michal Suchanek <msuchanek@...e.de>,
        dri-devel@...ts.freedesktop.org, linux-fbdev@...r.kernel.org,
        Thomas Zimmermann <tzimmermann@...e.de>
Cc:     Borislav Petkov <bp@...en8.de>,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>,
        Dave Hansen <dave.hansen@...ux.intel.com>, x86@...nel.org,
        "H. Peter Anvin" <hpa@...or.com>, Martin Mares <mj@....cz>,
        Helge Deller <deller@....de>, Ard Biesheuvel <ardb@...nel.org>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Sudeep Holla <sudeep.holla@....com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski@...onical.com>,
        Arnd Bergmann <arnd@...db.de>,
        Geert Uytterhoeven <geert+renesas@...der.be>,
        Cristian Marussi <cristian.marussi@....com>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        David Herrmann <dh.herrmann@...il.com>,
        linux-kernel@...r.kernel.org, linux-video@...ey.karlin.mff.cuni.cz,
        linux-efi@...r.kernel.org, Borislav Petkov <bp@...e.de>
Subject: Re: [PATCH v4 2/3] sysfb: Enable boot time VESA graphic mode
 selection

On 2/25/22 21:51, Michal Suchanek wrote:
> Since switch to simplefb/simpledrm VESA graphic mode selection with vga=
> kernel parameter is no longer available with legacy BIOS.
> 
> The x86 realmode boot code enables the VESA graphic modes when option
> FB_BOOT_VESA_SUPPORT is enabled.
> 
> This option is selected by vesafb but not simplefb/simpledrm.
> 
> To enable use of VESA modes with simplefb in legacy BIOS boot mode drop
> dependency of BOOT_VESA_SUPPORT on FB, also drop the FB_ prefix. Select
> the option from sysfb rather than the drivers that depend on it.
> 
> The BOOT_VESA_SUPPORT is not specific to framebuffer but rather to x86
> platform, move it from fbdev to x86 Kconfig.
> 
> Fixes: e3263ab389a7 ("x86: provide platform-devices for boot-framebuffers")
> Signed-off-by: Michal Suchanek <msuchanek@...e.de>
> Acked-by: Borislav Petkov <bp@...e.de>
> ---

Reviewed-by: Javier Martinez Canillas <javierm@...hat.com>

-- 
Best regards,

Javier Martinez Canillas
Linux Engineering
Red Hat