linux-kernel - Re: [PATCH v9 00/11] vgaarb: Rework default VGA device selection

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220225221523.GA385757@bhelgaas>
Date:   Fri, 25 Feb 2022 16:15:23 -0600
From:   Bjorn Helgaas <helgaas@...nel.org>
To:     Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
        Maxime Ripard <mripard@...nel.org>,
        Thomas Zimmermann <tzimmermann@...e.de>
Cc:     David Airlie <airlied@...ux.ie>, linux-pci@...r.kernel.org,
        linux-kernel@...r.kernel.org, dri-devel@...ts.freedesktop.org,
        Bjorn Helgaas <bhelgaas@...gle.com>,
        Xuefeng Li <lixuefeng@...ngson.cn>,
        Huacai Chen <chenhuacai@...ngson.cn>
Subject: Re: [PATCH v9 00/11] vgaarb: Rework default VGA device selection

On Thu, Feb 24, 2022 at 04:47:42PM -0600, Bjorn Helgaas wrote:
> From: Bjorn Helgaas <bhelgaas@...gle.com>
> 
> Current default VGA device selection fails in some cases because part of it
> is done in the vga_arb_device_init() subsys_initcall, and some arches
> enumerate PCI devices in pcibios_init(), which runs *after* that.
> 
> The big change from the v8 posting is that this moves vgaarb.c from
> drivers/gpu/vga to drivers/pci because it really has nothing to do with
> GPUs or DRM.

I provisionally applied this to pci/vga and put it into -next just
to get a little runtime on it.

But I'd prefer not to unilaterally yank this out of drivers/gpu
without a consensus from the GPU folks that this is the right thing to
do.

Any thoughts?  If it seems OK to you, I think patch 1/11 (the move
itself) is all you would need to look at, although of course I would
still be grateful for any review and feedback on the rest.

After it's in drivers/pci, all the blame for any issues would come my
way.

Bjorn