linux-kernel - Re: [RFC FATCH] x86/Hyper-V: Add SEV negotiate protocol support in Isolation VM.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220225051254.GA4017@anparri>
Date:   Fri, 25 Feb 2022 06:12:54 +0100
From:   Andrea Parri <parri.andrea@...il.com>
To:     Tianyu Lan <ltykernel@...il.com>
Cc:     kys@...rosoft.com, haiyangz@...rosoft.com, sthemmin@...rosoft.com,
        wei.liu@...nel.org, decui@...rosoft.com, tglx@...utronix.de,
        mingo@...hat.com, bp@...en8.de, dave.hansen@...ux.intel.com,
        x86@...nel.org, hpa@...or.com, brijesh.singh@....com,
        michael.roth@....com, jroedel@...e.de, Tianyu.Lan@...rosoft.com,
        thomas.lendacky@....com, michael.h.kelley@...rosoft.com,
        linux-hyperv@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [RFC FATCH] x86/Hyper-V: Add SEV negotiate protocol support in
 Isolation VM.

Nits:

> Hyper-V Isolation VM code uses sev_es_ghcb_hv_call() to read/write MSR
> via ghcb page. The SEV-ES guest should call the sev_es_negotiate_protocol()

ghcb page -> GHCB page

call the sev_es_negotiate_protocol() -> call sev_es_negotiate_protocol()
	(or -- call the sev_es_negotiate_protocol() function)

> to negotiate the GHCB protocol version before establishing the GHCB. Call
> sev_es_negotiate_protocol() in the hyperv_init_ghcb().

in the hyperv_init_ghcb() -> in hyperv_init_ghcb()

(similarly elsewhere).

  Andrea