linux-kernel - Re: [PATCH v6 0/7] kernfs: Introduce hashed mutexes to replace global kernfs_open_file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <39b74b28-d029-ad05-0f73-2db8c8eefe92@oracle.com>
Date:   Fri, 25 Feb 2022 16:43:48 +1100
From:   Imran Khan <imran.f.khan@...cle.com>
To:     Tejun Heo <tj@...nel.org>
Cc:     gregkh@...uxfoundation.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v6 0/7] kernfs: Introduce hashed mutexes to replace global
 kernfs_open_file_mutex.

Hello Tejun,

Thanks again for reviewing this. I have refactored the code.
I have also added a document to describe lock usage and proof
of correctness in the new patch set at [1]. This took some time
but it can highlight if I have understood something wrong while
making these changes.

[1]
https://lore.kernel.org/lkml/20220225052116.1243150-1-imran.f.khan@oracle.com/

Thanks
 -- Imran

On 15/2/22 5:15 am, Tejun Heo wrote:
> Hello,
> 
> The patchset generally looks good to me but I think it can be split a bit
> better and the locking helper code can be more compacted. Also, it'd be
> great o include the benchmark method and result in the commit log so that it
> can be looked up easily later. It just has to be in one of the patch
> descriptions whether the first or last of the series and the rest can refer
> to it.
> 
> Thanks.
>