linux-kernel - Re: [PATCH v3] net/tcp: Merge TCP-MD5 inbound callbacks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 24 Feb 2022 21:57:26 -0800
From:   Eric Dumazet <edumazet@...gle.com>
To:     David Ahern <dsahern@...nel.org>
Cc:     Dmitry Safonov <dima@...sta.com>, linux-kernel@...r.kernel.org,
        Dmitry Safonov <0x7f454c46@...il.com>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Hideaki YOSHIFUJI <yoshfuji@...ux-ipv6.org>,
        netdev@...r.kernel.org
Subject: Re: [PATCH v3] net/tcp: Merge TCP-MD5 inbound callbacks

On Thu, Feb 24, 2022 at 7:16 PM David Ahern <dsahern@...nel.org> wrote:
>
> On 2/23/22 10:57 AM, Dmitry Safonov wrote:
> > The functions do essentially the same work to verify TCP-MD5 sign.
> > Code can be merged into one family-independent function in order to
> > reduce copy'n'paste and generated code.
> > Later with TCP-AO option added, this will allow to create one function
> > that's responsible for segment verification, that will have all the
> > different checks for MD5/AO/non-signed packets, which in turn will help
> > to see checks for all corner-cases in one function, rather than spread
> > around different families and functions.
> >
> > Cc: Eric Dumazet <edumazet@...gle.com>
> > Cc: "David S. Miller" <davem@...emloft.net>
> > Cc: Jakub Kicinski <kuba@...nel.org>
> > Cc: Hideaki YOSHIFUJI <yoshfuji@...ux-ipv6.org>
> > Cc: David Ahern <dsahern@...nel.org>
> > Cc: netdev@...r.kernel.org
> > Signed-off-by: Dmitry Safonov <dima@...sta.com>
> > ---
> > v2: Rebased on net-next
> > v3: Correct rebase on net-next for !CONFIG_TCP_MD5
> >
> >  include/net/tcp.h   | 13 ++++++++
> >  net/ipv4/tcp.c      | 70 ++++++++++++++++++++++++++++++++++++++++
> >  net/ipv4/tcp_ipv4.c | 78 +++------------------------------------------
> >  net/ipv6/tcp_ipv6.c | 62 +++--------------------------------
> >  4 files changed, 92 insertions(+), 131 deletions(-)
> >
>
>
> Reviewed-by: David Ahern <dsahern@...nel.org>

SGTM, thanks

Reviewed-by: Eric Dumazet <edumazet@...gle.com>