linux-kernel - [PATCH] lib: maple_tree: fix boolreturn.cocci warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20220225063101.891725-1-wanjiabing@vivo.com>
Date:   Fri, 25 Feb 2022 14:31:01 +0800
From:   Wan Jiabing <wanjiabing@...o.com>
To:     "Liam R. Howlett" <Liam.Howlett@...cle.com>, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org
Cc:     jiabing.wan@...com, Wan Jiabing <wanjiabing@...o.com>
Subject: [PATCH] lib: maple_tree: fix boolreturn.cocci warning

Fix following coccicheck warning:
./lib/maple_tree.c:4177:9-10: WARNING: return of 0/1 in function
mas_wr_append with return type bool.

Signed-off-by: Wan Jiabing <wanjiabing@...o.com>
---
 lib/maple_tree.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/lib/maple_tree.c b/lib/maple_tree.c
index 5f7295ba0309..933483726b85 100644
--- a/lib/maple_tree.c
+++ b/lib/maple_tree.c
@@ -4174,7 +4174,7 @@ static inline bool mas_wr_append(struct ma_wr_state *wr_mas)
 		mas->offset = new_end;
 		wr_mas->pivots[end] = mas->index - 1;
 
-		return 1;
+		return true;
 	} else if ((mas->index == wr_mas->r_min) && (mas->last < wr_mas->r_max)) {
 		if (new_end < node_pivots)
 			wr_mas->pivots[new_end] = wr_mas->pivots[end];
@@ -4185,9 +4185,9 @@ static inline bool mas_wr_append(struct ma_wr_state *wr_mas)
 
 		wr_mas->pivots[end] = mas->last;
 		rcu_assign_pointer(wr_mas->slots[end], wr_mas->entry);
-		return 1;
+		return true;
 	}
-	return 0;
+	return false;
 }
 
 static inline void mas_wr_modify(struct ma_wr_state *wr_mas)
-- 
2.35.1