linux-kernel - Re: [PATCH] xhci: fix runtime PM imbalance in USB2 resume

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CH0PR12MB5089EB28FAA6DF61F57F6D09AC3E9@CH0PR12MB5089.namprd12.prod.outlook.com>
Date:   Fri, 25 Feb 2022 06:40:53 +0000
From:   Henry Lin <henryl@...dia.com>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
CC:     "mathias.nyman@...el.com" <mathias.nyman@...el.com>,
        "linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] xhci: fix runtime PM imbalance in USB2 resume

It fixes side effect from below change. 

commit a231ec41e6f6433daf4c693f169f6c5cfda8cb9d
Author: Mathias Nyman <mathias.nyman@...ux.intel.com>
Date:   Fri Dec 7 16:19:35 2018 +0200

    xhci: refactor U0 link state handling in get_port_status

    Move U0 link state handing to USB3 and USB2 specific functions

    Note that
    bus_state->resuming_ports:
    bus_state->resume_done[]:
    are only used for USB2, and don't need to cleared for USB3 ports

    No functional changes

    Signed-off-by: Mathias Nyman <mathias.nyman@...ux.intel.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>

--nvpublic
________________________________________
From: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Sent: Friday, February 25, 2022 2:23 PM
To: Henry Lin
Cc: mathias.nyman@...el.com; linux-usb@...r.kernel.org; linux-kernel@...r.kernel.org
Subject: Re: [PATCH] xhci: fix runtime PM imbalance in USB2 resume

External email: Use caution opening links or attachments


On Fri, Feb 25, 2022 at 01:53:11PM +0800, Henry Lin wrote:
> USB2 resume starts with usb_hcd_start_port_resume() in port status
> change handling for RESUME link state. usb_hcd_end_port_resume() call is
> needed to keep runtime PM balance.
>
> Signed-off-by: Henry Lin <henryl@...dia.com>
> ---
>  drivers/usb/host/xhci-hub.c | 2 ++
>  1 file changed, 2 insertions(+)

What commit does this fix?