[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20220225004716.epyhpxi5lunphzi4@treble>
Date: Thu, 24 Feb 2022 16:47:16 -0800
From: Josh Poimboeuf <jpoimboe@...hat.com>
To: Peter Zijlstra <peterz@...radead.org>
Cc: x86@...nel.org, joao@...rdrivepizza.com, hjl.tools@...il.com,
andrew.cooper3@...rix.com, linux-kernel@...r.kernel.org,
ndesaulniers@...gle.com, keescook@...omium.org,
samitolvanen@...gle.com, mark.rutland@....com,
alyssa.milburn@...el.com, mbenes@...e.cz, rostedt@...dmis.org,
mhiramat@...nel.org, alexei.starovoitov@...il.com
Subject: Re: [PATCH v2 21/39] x86/ibt: Annotate text references
On Thu, Feb 24, 2022 at 03:51:59PM +0100, Peter Zijlstra wrote:
> @@ -563,12 +564,14 @@ SYM_CODE_END(\asmsym)
> .align 16
> .globl __irqentry_text_start
> __irqentry_text_start:
> + ANNOTATE_NOENDBR // unwinders
But the instruction here (first idt entry) actually does have an
endbr64...
Also I'm wondering if it would make sense to create an
'idt_entry_<vector>' symbol for each entry so objtool knows to validate
their ENDBRs.
> +++ b/arch/x86/lib/retpoline.S
> @@ -12,6 +12,8 @@
>
> .section .text.__x86.indirect_thunk
>
> + ANNOTATE_NOENDBR // apply_retpolines
This should probably go after __x86_indirect_thunk_array?
--
Josh
Powered by blists - more mailing lists