linux-kernel - Re: [PATCH v2] xen/netfront: destroy queues before real_num_tx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 25 Feb 2022 10:40:10 +0000
From:   patchwork-bot+netdevbpf@...nel.org
To:     Marek Marczykowski-Górecki <marmarek@...isiblethingslab@...codeaurora.org,
        .com>@ci.codeaurora.org
Cc:     linux-kernel@...r.kernel.org, stable@...r.kernel.org,
        boris.ostrovsky@...cle.com, jgross@...e.com,
        sstabellini@...nel.org, davem@...emloft.net, kuba@...nel.org,
        atenart@...nel.org, xen-devel@...ts.xenproject.org,
        netdev@...r.kernel.org
Subject: Re: [PATCH v2] xen/netfront: destroy queues before real_num_tx_queues is
 zeroed

Hello:

This patch was applied to netdev/net.git (master)
by David S. Miller <davem@...emloft.net>:

On Wed, 23 Feb 2022 22:19:54 +0100 you wrote:
> xennet_destroy_queues() relies on info->netdev->real_num_tx_queues to
> delete queues. Since d7dac083414eb5bb99a6d2ed53dc2c1b405224e5
> ("net-sysfs: update the queue counts in the unregistration path"),
> unregister_netdev() indirectly sets real_num_tx_queues to 0. Those two
> facts together means, that xennet_destroy_queues() called from
> xennet_remove() cannot do its job, because it's called after
> unregister_netdev(). This results in kfree-ing queues that are still
> linked in napi, which ultimately crashes:
> 
> [...]

Here is the summary with links:
  - [v2] xen/netfront: destroy queues before real_num_tx_queues is zeroed
    https://git.kernel.org/netdev/net/c/dcf4ff7a48e7

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html