linux-kernel - Re: [PATCH v6 0/7] KVM: SVM: Add initial GHCB protocol version 2 support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YhiyLJOHyfA7sLMt@8bytes.org>
Date:   Fri, 25 Feb 2022 11:40:44 +0100
From:   Joerg Roedel <joro@...tes.org>
To:     Paolo Bonzini <pbonzini@...hat.com>
Cc:     Sean Christopherson <seanjc@...gle.com>,
        Vitaly Kuznetsov <vkuznets@...hat.com>,
        Wanpeng Li <wanpengli@...cent.com>,
        Jim Mattson <jmattson@...gle.com>, x86@...nel.org,
        Brijesh Singh <brijesh.singh@....com>,
        Tom Lendacky <thomas.lendacky@....com>, kvm@...r.kernel.org,
        linux-kernel@...r.kernel.org, Joerg Roedel <jroedel@...e.de>
Subject: Re: [PATCH v6 0/7] KVM: SVM: Add initial GHCB protocol version 2
 support

Gentle ping. Any comments on these patches?

On Tue, Jan 25, 2022 at 03:16:19PM +0100, Joerg Roedel wrote:
> From: Joerg Roedel <jroedel@...e.de>
> 
> Hi,
> 
> here is a small set of patches which I originally took from the
> pending SEV-SNP patch-sets to enable basic support for GHCB protocol
> version 2. Meanwhile a couple of other patches from Sean
> Christopherson have been added.
> 
> When SEV-SNP is not supported, only two new MSR protocol VMGEXIT calls
> are required:
> 
> 	- MSR-based AP-reset-hold
> 	- MSR-based HV-feature-request
> 
> These calls are implemented here and then the protocol is lifted to
> version 2.
> 
> This is submitted separately because the MSR-based AP-reset-hold call
> is required to support kexec/kdump in SEV-ES guests.
> 
> The previous version can be found here:
> 
> 	https://lore.kernel.org/kvm/20211020124416.24523-1-joro@8bytes.org/
> 
> Regards,
> 
> 	Joerg
> 
> Changes v5->v6:
> 
> 	- Rebased to v5.17-rc1
> 	- Added changes requested by Sean Christopherson
> 
> Brijesh Singh (2):
>   KVM: SVM: Add support for Hypervisor Feature support MSR protocol
>   KVM: SVM: Increase supported GHCB protocol version
> 
> Joerg Roedel (2):
>   KVM: SVM: Get rid of set_ghcb_msr() and *ghcb_msr_bits() functions
>   KVM: SVM: Move kvm_emulate_ap_reset_hold() to AMD specific code
> 
> Sean Christopherson (2):
>   KVM: SVM: Add helper to generate GHCB MSR verson info, and drop macro
>   KVM: SVM: Set "released" on INIT-SIPI iff SEV-ES vCPU was in AP reset
>     hold
> 
> Tom Lendacky (1):
>   KVM: SVM: Add support to handle AP reset MSR protocol
> 
>  arch/x86/include/asm/kvm_host.h   |   2 +-
>  arch/x86/include/asm/sev-common.h |  18 ++--
>  arch/x86/include/uapi/asm/svm.h   |   1 +
>  arch/x86/kvm/svm/sev.c            | 169 ++++++++++++++++++++----------
>  arch/x86/kvm/svm/svm.c            |  13 ++-
>  arch/x86/kvm/svm/svm.h            |  10 +-
>  arch/x86/kvm/x86.c                |  12 +--
>  7 files changed, 137 insertions(+), 88 deletions(-)
> 
> 
> base-commit: e783362eb54cd99b2cac8b3a9aeac942e6f6ac07
> -- 
> 2.34.1