lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 25 Feb 2022 13:57:42 +0100 From: Peter Zijlstra <peterz@...radead.org> To: Josh Poimboeuf <jpoimboe@...hat.com> Cc: x86@...nel.org, joao@...rdrivepizza.com, hjl.tools@...il.com, andrew.cooper3@...rix.com, linux-kernel@...r.kernel.org, ndesaulniers@...gle.com, keescook@...omium.org, samitolvanen@...gle.com, mark.rutland@....com, alyssa.milburn@...el.com, mbenes@...e.cz, rostedt@...dmis.org, mhiramat@...nel.org, alexei.starovoitov@...il.com Subject: Re: [PATCH v2 21/39] x86/ibt: Annotate text references On Thu, Feb 24, 2022 at 04:47:16PM -0800, Josh Poimboeuf wrote: > On Thu, Feb 24, 2022 at 03:51:59PM +0100, Peter Zijlstra wrote: > > @@ -563,12 +564,14 @@ SYM_CODE_END(\asmsym) > > .align 16 > > .globl __irqentry_text_start > > __irqentry_text_start: > > + ANNOTATE_NOENDBR // unwinders > > But the instruction here (first idt entry) actually does have an > endbr64... > --- a/tools/objtool/check.c +++ b/tools/objtool/check.c @@ -2023,6 +2023,9 @@ static int read_noendbr_hints(struct obj return -1; } + if (insn->type == INSN_ENDBR) + WARN_FUNC("ANNOTATE_NOENDBR on ENDBR", insn->sec, insn->offset); + insn->noendbr = 1; } vmlinux.o: warning: objtool: .entry.text+0x160: ANNOTATE_NOENDBR on ENDBR vmlinux.o: warning: objtool: xen_pvh_init()+0x0: ANNOTATE_NOENDBR on ENDBR right you are... /me goes fix
Powered by blists - more mailing lists