linux-kernel - Re: [PATCH 1/1] usb: gadget: tegra-xudc: Do not program SPARAM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YhjXKLVYgpop27R9@orome>
Date:   Fri, 25 Feb 2022 14:18:32 +0100
From:   Thierry Reding <thierry.reding@...il.com>
To:     Wayne Chang <waynec@...dia.com>
Cc:     balbi@...nel.org, gregkh@...uxfoundation.org, jonathanh@...dia.com,
        zhangqilong3@...wei.com, yangyingliang@...wei.com,
        rikard.falkeborn@...il.com, chunfeng.yun@...iatek.com,
        linux-usb@...r.kernel.org, linux-tegra@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/1] usb: gadget: tegra-xudc: Do not program SPARAM

On Fri, Jan 07, 2022 at 05:04:43PM +0800, Wayne Chang wrote:
> According to the Tegra Technical Reference Manual, SPARAM
> is a read-only register and should not be programmed in
> the driver.
> 
> The change removes the wrong SPARAM usage.
> 
> Signed-off-by: Wayne Chang <waynec@...dia.com>
> ---
>  drivers/usb/gadget/udc/tegra-xudc.c | 8 --------
>  1 file changed, 8 deletions(-)

What's the impact on this? Does it fix a bug? Or is it more of a
cosmetic change?

Thierry

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)