linux-kernel - Re: [PATCH] KVM: arm64: fix semicolon.cocci warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5ba4356d4d526d72118664dd93d5f6f2@kernel.org>
Date:   Fri, 25 Feb 2022 13:25:28 +0000
From:   Marc Zyngier <maz@...nel.org>
To:     Will Deacon <will@...nel.org>
Cc:     kernel test robot <lkp@...el.com>, kbuild-all@...ts.01.org,
        linux-kernel@...r.kernel.org,
        Linux Memory Management List <linux-mm@...ck.org>,
        Catalin Marinas <catalin.marinas@....com>,
        kvmarm@...ts.cs.columbia.edu, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH] KVM: arm64: fix semicolon.cocci warnings

On 2022-02-25 12:29, Will Deacon wrote:
> On Fri, Feb 25, 2022 at 04:07:24AM +0800, kernel test robot wrote:
>> From: kernel test robot <lkp@...el.com>
>> 
>> arch/arm64/kvm/psci.c:372:3-4: Unneeded semicolon
>> 
>> 
>>  Remove unneeded semicolon.
>> 
>> Generated by: scripts/coccinelle/misc/semicolon.cocci
>> 
>> Fixes: d43583b890e7 ("KVM: arm64: Expose PSCI SYSTEM_RESET2 call to 
>> the guest")
>> CC: Will Deacon <will@...nel.org>
>> Reported-by: kernel test robot <lkp@...el.com>
>> Signed-off-by: kernel test robot <lkp@...el.com>
>> ---
>> 
>> tree:   
>> https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git 
>> master
>> head:   d4a0ae62a277377de396850ed4b709b6bd9b7326
>> commit: d43583b890e7cb0078d13d056753a56602b92406 [7067/7915] KVM: 
>> arm64: Expose PSCI SYSTEM_RESET2 call to the guest
>> :::::: branch date: 18 hours ago
>> :::::: commit date: 3 days ago
>> 
>>  arch/arm64/kvm/psci.c |    2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>> 
>> --- a/arch/arm64/kvm/psci.c
>> +++ b/arch/arm64/kvm/psci.c
>> @@ -369,7 +369,7 @@ static int kvm_psci_1_x_call(struct kvm_
>>  				ret = 0;
>>  			}
>>  			break;
>> -		};
>> +		}
> 
> Acked-by: Will Deacon <will@...nel.org>
> 
> but I really don't think this needs a Fixes: tag

The Fixes: really isn't warranted, there is a previous patch fixing
the same thing already[1], and there is *another* '};' typo in the
same file that the robot failed to pick on...

If you don't mind, I'll add your Ack to the original fix, and squash
the fix for the fix into it.

[1] 
https://lore.kernel.org/r/20220223092750.1934130-1-deng.changcheng@zte.com.cn
-- 
Jazz is not dead. It just smells funny...