linux-kernel - Re: [PATCH] KVM: arm64: Remove unneeded semicolon

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 25 Feb 2022 13:35:29 +0000
From:   Marc Zyngier <maz@...nel.org>
To:     cgel.zte@...il.com
Cc:     james.morse@....com, alexandru.elisei@....com,
        suzuki.poulose@....com, catalin.marinas@....com, will@...nel.org,
        linux-arm-kernel@...ts.infradead.org, kvmarm@...ts.cs.columbia.edu,
        linux-kernel@...r.kernel.org,
        Changcheng Deng <deng.changcheng@....com.cn>,
        Zeal Robot <zealci@....com.cn>, will@...nel.org
Subject: Re: [PATCH] KVM: arm64: Remove unneeded semicolon

On 2022-02-23 09:27, cgel.zte@...il.com wrote:
> From: Changcheng Deng <deng.changcheng@....com.cn>
> 
> Fix the following coccicheck review:
> ./arch/arm64/kvm/psci.c: 379: 3-4: Unneeded semicolon
> 
> Reported-by: Zeal Robot <zealci@....com.cn>
> Signed-off-by: Changcheng Deng <deng.changcheng@....com.cn>
> ---
>  arch/arm64/kvm/psci.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/kvm/psci.c b/arch/arm64/kvm/psci.c
> index 0a00ef250725..3b16dae4ab3d 100644
> --- a/arch/arm64/kvm/psci.c
> +++ b/arch/arm64/kvm/psci.c
> @@ -376,7 +376,7 @@ static int kvm_psci_1_x_call(struct kvm_vcpu
> *vcpu, u32 minor)
>  				ret = 0;
>  			}
>  			break;
> -		};
> +		}
>  		fallthrough;
>  	default:
>  		return kvm_psci_0_2_call(vcpu);

Thanks for that. You may want to check why your script didn't pick
this particular instance of the same defect:

diff --git a/arch/arm64/kvm/psci.c b/arch/arm64/kvm/psci.c
index b43adf7dc29f..0d48d1e7291d 100644
--- a/arch/arm64/kvm/psci.c
+++ b/arch/arm64/kvm/psci.c
@@ -438,7 +438,7 @@ int kvm_psci_call(struct kvm_vcpu *vcpu)
  		return kvm_psci_0_1_call(vcpu);
  	default:
  		return -EINVAL;
-	};
+	}
  }

  int kvm_arm_get_fw_num_regs(struct kvm_vcpu *vcpu)

I'll squash it into you patch and push it into -next.

Thanks,

         M.
-- 
Jazz is not dead. It just smells funny...