linux-kernel - Re: Strange output on the console

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220225084256.071dcf82@gandalf.local.home>
Date:   Fri, 25 Feb 2022 08:42:56 -0500
From:   Steven Rostedt <rostedt@...dmis.org>
To:     Sergey Senozhatsky <senozhatsky@...omium.org>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        Petr Mladek <pmladek@...e.com>,
        John Ogness <john.ogness@...utronix.de>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Wander Lairson Costa <wander@...hat.com>,
        Willy Tarreau <w@....eu>,
        David Laight <David.Laight@...lab.com>
Subject: Re: Strange output on the console

On Fri, 25 Feb 2022 08:32:09 -0500
Steven Rostedt <rostedt@...dmis.org> wrote:

> On Fri, 25 Feb 2022 14:07:00 +0900
> Sergey Senozhatsky <senozhatsky@...omium.org> wrote:
> 
> > > Steven, did you notice this recently?
> > > May I perhaps suggest git bisect? (sorry)    
> > 
> > On the off chance - do you have this revert in your kernel?
> > 
> > commit 6a7b9f002eca6788d346c16a6ff0c218b41f8d1d
> > Author: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> > Date:   Wed Jan 26 14:33:58 2022 +0100
> > 
> >     Revert "tty: serial: Use fifo in 8250 console driver"
> > 
> >     This reverts commit 5021d709b31b8a14317998a33cbc78be0de9ab30.
> > 
> >     The patch is still a bit buggy, and this breaks some other hardware
> >     types.  It needs to be resubmitted in a non-buggy way, and make sure the
> >     other hardware types also continue to work properly.  
> 
> My tree does not have this.
> 
> I just applied it and I'm building now. I'll let you know if this fixes the
> issue or not.

Mystery solved. Thanks Sergey!

After applying the above revert patch the funky characters go away.
Removing the revert (putting back the problem commit) the problem reappears.

Greg,

I have the hardware that the code breaks. I will be willing to test the new
changes to make sure it's done in a "non-buggy" way. At least for my
hardware (two boxes that had the issue, but slightly different).


-- Steve