linux-kernel - Re: [PATCH] staging: wfx: correct error handling code in wfx_init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 25 Feb 2022 18:03:15 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     Jia-Ju Bai <baijiaju1990@...il.com>
Cc:     jerome.pouiller@...abs.com, gregkh@...uxfoundation.org,
        linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: wfx: correct error handling code in
 wfx_init_common()

Thanks, but someone already fixed part of this in linux-next and I think
they sent the patch for the rest, but it just hasn't been applied yet.

> @@ -337,8 +343,10 @@ struct wfx_dev *wfx_init_common(struct device *dev,
>  	wfx_init_hif_cmd(&wdev->hif_cmd);
>  	wdev->force_ps_timeout = -1;
>  
> -	if (devm_add_action_or_reset(dev, wfx_free_common, wdev))
> +	if (devm_add_action_or_reset(dev, wfx_free_common, wdev)) {
> +		ieee80211_free_hw(hw);

This introduces a double free.  The devm_add_action_or_reset() will call
wfx_free_common() on failure.

>  		return NULL;
> +	}
>  
>  	return wdev;

regards,
dan carpenter