lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 25 Feb 2022 16:49:46 +0100 From: Arnd Bergmann <arnd@...db.de> To: Guo Ren <guoren@...nel.org> Cc: Arnd Bergmann <arnd@...db.de>, Palmer Dabbelt <palmer@...belt.com>, Anup Patel <anup@...infault.org>, gregkh <gregkh@...uxfoundation.org>, liush <liush@...winnertech.com>, Wei Fu <wefu@...hat.com>, Drew Fustini <drew@...gleboard.org>, Wang Junqiang <wangjunqiang@...as.ac.cn>, Christoph Hellwig <hch@....de>, linux-arch <linux-arch@...r.kernel.org>, Linux Kernel Mailing List <linux-kernel@...r.kernel.org>, linux-riscv <linux-riscv@...ts.infradead.org>, linux-csky@...r.kernel.org, linux-s390 <linux-s390@...r.kernel.org>, sparclinux <sparclinux@...r.kernel.org>, linuxppc-dev <linuxppc-dev@...ts.ozlabs.org>, Parisc List <linux-parisc@...r.kernel.org>, "open list:BROADCOM NVRAM DRIVER" <linux-mips@...r.kernel.org>, Linux ARM <linux-arm-kernel@...ts.infradead.org>, "the arch/x86 maintainers" <x86@...nel.org>, Guo Ren <guoren@...ux.alibaba.com> Subject: Re: [PATCH V6 16/20] riscv: compat: vdso: Add rv32 VDSO base code implementation On Fri, Feb 25, 2022 at 4:42 PM Guo Ren <guoren@...nel.org> wrote: > > Hi Arnd & Palmer, > > Here is the new modified compat_vdso/Makefile, please have a look, > first. Then I would update it to v7: > =========================================== > # SPDX-License-Identifier: GPL-2.0-only > # > # Makefile for compat_vdso > # > > # Symbols present in the compat_vdso > compat_vdso-syms = rt_sigreturn > compat_vdso-syms += getcpu > compat_vdso-syms += flush_icache > > ifdef CROSS_COMPILE_COMPAT > COMPAT_CC := $(CROSS_COMPILE_COMPAT)gcc > COMPAT_LD := $(CROSS_COMPILE_COMPAT)ld > else > COMPAT_CC := $(CC) > COMPAT_LD := $(LD) > endif > > COMPAT_CC_FLAGS := -march=rv32g -mabi=ilp32 > COMPAT_LD_FLAGS := -melf32lriscv Have you come across a case in which a separate cross toolchain is required? If not, I would leave this out and just set the flags for the normal toolchain. I also think it would be a nicer split to build the two vdso variants as vdso64/vdso32 rather than vdso/compat_vdso. That way, the build procedure can be kept as close as possible to the native 32-bit build. Arnd
Powered by blists - more mailing lists