lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 25 Feb 2022 22:00:21 -0800 From: Dmitry Torokhov <dmitry.torokhov@...il.com> To: Stephen Boyd <swboyd@...omium.org> Cc: Benjamin Tissoires <benjamin.tissoires@...hat.com>, Jiri Kosina <jikos@...nel.org>, Sean O'Brien <seobrien@...omium.org>, linux-input@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH] HID: vivaldi: fix sysfs attributes leak On Fri, Feb 25, 2022 at 08:55:26PM -0800, Stephen Boyd wrote: > Quoting Dmitry Torokhov (2022-02-25 17:18:58) > > The driver creates the top row map sysfs attribute in input_configured() > > method; unfortunately we do not have a callback that is executed when HID > > interface is unbound, thus we are leaking these sysfs attributes, for > > example when device is disconnected. > > > > To fix it let's switch to managed version of adding sysfs attributes which > > will ensure that they are destroyed when the driver is unbound. > > > > Fixes: 14c9c014babe ("HID: add vivaldi HID driver") > > Signed-off-by: Dmitry Torokhov <dmitry.torokhov@...il.com> > > --- > > Makes sense > > Tested-by: Stephen Boyd <swboyd@...omium.org> > Reviewed-by: Stephen Boyd <swboyd@...omium.org> > > will you make a similar change for the hid-google-hammer driver? Yeah, I was taking a closer look at your series and that was the result of it. Thanks. -- Dmitry
Powered by blists - more mailing lists