linux-kernel - Re: [PATCH v2] drivers: ddcci: upstream DDCCI driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YhnX+Shp7nRkbvSG@kroah.com>
Date:   Sat, 26 Feb 2022 08:34:17 +0100
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Yusuf Khan <yusisamerican@...il.com>
Cc:     linux-kernel@...r.kernel.org, jasowang@...hat.com,
        mikelley@...rosoft.com, mst@...hat.com, javier@...igon.com,
        arnd@...db.de, will@...nel.org, axboe@...nel.dk,
        bjorn.andersson@...aro.org
Subject: Re: [PATCH v2] drivers: ddcci: upstream DDCCI driver

On Fri, Feb 25, 2022 at 08:04:29PM -0800, Yusuf Khan wrote:
> This patch upstreams the DDCCI driver by Christoph Grenz into
> the kernel. The original gitlab page is loacted at https://gitlab
> .com/ddcci-driver-linux/ddcci-driver-linux/-/tree/master.
> 
> Signed-off-by: Yusuf Khan <yusisamerican@...il.com>
> ---
>  drivers/Kconfig                 |    2 +
>  drivers/Makefile                |    1 +
>  drivers/ddcci/Kconfig           |    5 +
>  drivers/ddcci/Makefile          |    3 +
>  drivers/ddcci/ddcci-backlight.c |  411 +++++++
>  drivers/ddcci/ddcci.c           | 1887 +++++++++++++++++++++++++++++++
>  include/linux/ddcci.h           |  164 +++

Also, you create a lot of sysfs files here, yet document none of them in
Documentation/ABI/ which will make tools like scripts/get_abi.pl
unhappy.  Please fix that in your next submission.

thanks,

greg k-h