linux-kernel - RE: [EXT] [PATCH] hwrng: cavium: fix NULL but dereferenced coccicheck error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 26 Feb 2022 08:16:56 +0000
From:   Sunil Kovvuri Goutham <sgoutham@...vell.com>
To:     Wan Jiabing <wanjiabing@...o.com>, Matt Mackall <mpm@...enic.com>,
        Herbert Xu <herbert@...dor.apana.org.au>,
        "linux-crypto@...r.kernel.org" <linux-crypto@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
CC:     "jiabing.wan@...com" <jiabing.wan@...com>
Subject: RE: [EXT] [PATCH] hwrng: cavium: fix NULL but dereferenced coccicheck
 error



> -----Original Message-----
> From: Wan Jiabing <wanjiabing@...o.com>
> Sent: Friday, February 25, 2022 12:09 PM
> To: Matt Mackall <mpm@...enic.com>; Herbert Xu
> <herbert@...dor.apana.org.au>; Sunil Kovvuri Goutham
> <sgoutham@...vell.com>; Wan Jiabing <wanjiabing@...o.com>; linux-
> crypto@...r.kernel.org; linux-kernel@...r.kernel.org
> Cc: jiabing.wan@...com
> Subject: [EXT] [PATCH] hwrng: cavium: fix NULL but dereferenced coccicheck
> error
> 
> External Email
> 
> ----------------------------------------------------------------------
> Fix following coccicheck warning:
> ./drivers/char/hw_random/cavium-rng-vf.c:182:17-20: ERROR:
> pdev is NULL but dereferenced.
> 
> Signed-off-by: Wan Jiabing <wanjiabing@...o.com>
> ---
>  drivers/char/hw_random/cavium-rng-vf.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/char/hw_random/cavium-rng-vf.c
> b/drivers/char/hw_random/cavium-rng-vf.c
> index 6f66919652bf..7c55f4cf4a8b 100644
> --- a/drivers/char/hw_random/cavium-rng-vf.c
> +++ b/drivers/char/hw_random/cavium-rng-vf.c
> @@ -179,7 +179,7 @@ static int cavium_map_pf_regs(struct cavium_rng
> *rng)
>  	pdev = pci_get_device(PCI_VENDOR_ID_CAVIUM,
>  			      PCI_DEVID_CAVIUM_RNG_PF, NULL);
>  	if (!pdev) {
> -		dev_err(&pdev->dev, "Cannot find RNG PF device\n");
> +		pr_err("Cannot find RNG PF device\n");
>  		return -EIO;
>  	}
> 
> --

Thanks for the fix.
Reviewed-by: Sunil Goutham <sgoutham@...vell.com>