[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20220226183531.05f5f0be@jic23-huawei>
Date: Sat, 26 Feb 2022 18:35:31 +0000
From: Jonathan Cameron <jic23@...nel.org>
To: Jagath Jog J <jagathjog1996@...il.com>
Cc: lars@...afoo.de, andy.shevchenko@...il.com, sst@...zta.fm,
robh+dt@...nel.org, linux-iio@...r.kernel.org,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v5 1/7] iio: potentiometer: Alignment to match the open
parenthesis
On Wed, 23 Feb 2022 22:05:19 +0530
Jagath Jog J <jagathjog1996@...il.com> wrote:
> Fix following checkpatch.pl check by removing blank space.
> CHECK: Alignment should match open parenthesis.
>
> Signed-off-by: Jagath Jog J <jagathjog1996@...il.com>
I didn't noticed before, but for future please put the driver name
in the patch titles!
iio: potentiometer: ds1803: xxxx
I'll fix up.
> ---
> drivers/iio/potentiometer/ds1803.c | 13 ++++++-------
> 1 file changed, 6 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/iio/potentiometer/ds1803.c b/drivers/iio/potentiometer/ds1803.c
> index 20b45407eaac..3c542a50ece6 100644
> --- a/drivers/iio/potentiometer/ds1803.c
> +++ b/drivers/iio/potentiometer/ds1803.c
> @@ -55,8 +55,8 @@ static const struct iio_chan_spec ds1803_channels[] = {
> };
>
> static int ds1803_read_raw(struct iio_dev *indio_dev,
> - struct iio_chan_spec const *chan,
> - int *val, int *val2, long mask)
> + struct iio_chan_spec const *chan,
> + int *val, int *val2, long mask)
> {
> struct ds1803_data *data = iio_priv(indio_dev);
> int pot = chan->channel;
> @@ -66,7 +66,7 @@ static int ds1803_read_raw(struct iio_dev *indio_dev,
> switch (mask) {
> case IIO_CHAN_INFO_RAW:
> ret = i2c_master_recv(data->client, result,
> - indio_dev->num_channels);
> + indio_dev->num_channels);
> if (ret < 0)
> return ret;
>
> @@ -83,8 +83,8 @@ static int ds1803_read_raw(struct iio_dev *indio_dev,
> }
>
> static int ds1803_write_raw(struct iio_dev *indio_dev,
> - struct iio_chan_spec const *chan,
> - int val, int val2, long mask)
> + struct iio_chan_spec const *chan,
> + int val, int val2, long mask)
> {
> struct ds1803_data *data = iio_priv(indio_dev);
> int pot = chan->channel;
> @@ -109,8 +109,7 @@ static const struct iio_info ds1803_info = {
> .write_raw = ds1803_write_raw,
> };
>
> -static int ds1803_probe(struct i2c_client *client,
> - const struct i2c_device_id *id)
> +static int ds1803_probe(struct i2c_client *client, const struct i2c_device_id *id)
> {
> struct device *dev = &client->dev;
> struct ds1803_data *data;
Powered by blists - more mailing lists