linux-kernel - Re: [PATCH v5 0/7] iio: potentiometer: Add support for DS3502

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sat, 26 Feb 2022 18:41:39 +0000
From:   Jonathan Cameron <jic23@...nel.org>
To:     Andy Shevchenko <andy.shevchenko@...il.com>
Cc:     Jagath Jog J <jagathjog1996@...il.com>,
        Lars-Peter Clausen <lars@...afoo.de>,
        Slawomir Stepien <sst@...zta.fm>,
        Rob Herring <robh+dt@...nel.org>,
        linux-iio <linux-iio@...r.kernel.org>,
        devicetree <devicetree@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v5 0/7] iio: potentiometer: Add support for DS3502

On Thu, 24 Feb 2022 02:47:53 +0200
Andy Shevchenko <andy.shevchenko@...il.com> wrote:

> On Wed, Feb 23, 2022 at 6:35 PM Jagath Jog J <jagathjog1996@...il.com> wrote:
> >
> > Add dt-bindings and support for Maxim DS3502 into existing ds1803 driver.
> > DS3502 is a 7 bit Nonvolatile Digital Potentiometer.  
> 
> LGTM, thanks!
> Reviewed-by: Andy Shevchenko <andy.shevchenko@...il.com>
> for the entire series,

Applied to the togreg branch of iio.git with the various tweaks I mentioned
in reply to individual patches.

Pushed out initially as testing to let 0-day run it's much more comprehensive
set of build tests against it than I run locally.

Thanks,

Jonathan

> 
> > Changes since v4:
> > 1. Included property.h header which has device_get_match_data()
> >    function prototype.
> > 2. Removed blank space in tag block of the commit message.
> > 3. Style changes for ds1803_cfg structure.
> >
> > Changes since v3:
> > 1. Dropped the chip type switch statement in read_raw function.
> > 2. Added device specific read function pointer in their structure.
> > 3. Added two separate functions to read values from two different types
> >    of devices.
> >
> > Changes since v2:
> > 1. Addressed Andy Shevchenko comments.
> > 2. Adding device name in Kconfig file.
> > 3. Spliting up of patch into 3 patches.
> > 4. Adding channel info into ds1803_cfg in separate patch.
> > 5. Dropping the use of enum in firmware data instead using previous
> >    pointer method for accessing device specific data.
> > 6. Separate patch for using firmware provided data instead of
> >    id->driver_data.
> > 7. Adding DS3502 support in separate patch.
> >
> > Changes since v1:
> > 1. Fixes the alignment to match the open parenthesis in separate patch.
> > 2. Adding available functionality for ds1803 driver in separate patch.
> > 3. Moving maxim_potentiometer members into ds1803_cfg structure.
> > 4. Droping of the INFO_ENABLE channel type.
> > 5. Firmware entry with data is used instead of id->driver_data to
> >    to retrieve the chip specific data.
> >
> > Jagath Jog J (7):
> >   iio: potentiometer: Alignment to match the open parenthesis
> >   iio: potentiometer: Add available functionality
> >   iio: potentiometer: Add channel information in device data
> >   iio: potentiometer: Change to firmware provided data
> >   iio: potentiometer: Add device specific read_raw function
> >   iio: potentiometer: Add support for Maxim DS3502
> >   dt-bindings: iio: potentiometer: Add Maxim DS3502 in trivial-devices
> >
> >  .../devicetree/bindings/trivial-devices.yaml  |   2 +
> >  drivers/iio/potentiometer/Kconfig             |   6 +-
> >  drivers/iio/potentiometer/ds1803.c            | 170 ++++++++++++++----
> >  3 files changed, 138 insertions(+), 40 deletions(-)
> >
> > --
> > 2.17.1
> >  
> 
>