| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Sun, 27 Feb 2022 03:14:05 +0800
From: kernel test robot <lkp@...el.com>
To: Hannes Reinecke <hare@...e.de>
Cc: llvm@...ts.linux.dev, kbuild-all@...ts.01.org,
linux-kernel@...r.kernel.org
Subject: [hare-scsi-devel:tls-upcall.v2 157/159]
drivers/nvme/host/tcp.c:678:7: warning: variable 'map' is uninitialized when
used here
tree: https://git.kernel.org/pub/scm/linux/kernel/git/hare/scsi-devel.git tls-upcall.v2
head: 21b520ae0b338bd30496feb1ca90a2820dab7a65
commit: 294875f63a598198387eda2c7f5fc00c3ac94b7a [157/159] nvme-tcp: decode c2h term PDU
config: hexagon-randconfig-r023-20220226 (https://download.01.org/0day-ci/archive/20220226/202202262236.UVE9DltW-lkp@intel.com/config)
compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project d271fc04d5b97b12e6b797c6067d3c96a8d7470e)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://git.kernel.org/pub/scm/linux/kernel/git/hare/scsi-devel.git/commit/?id=294875f63a598198387eda2c7f5fc00c3ac94b7a
git remote add hare-scsi-devel https://git.kernel.org/pub/scm/linux/kernel/git/hare/scsi-devel.git
git fetch --no-tags hare-scsi-devel tls-upcall.v2
git checkout 294875f63a598198387eda2c7f5fc00c3ac94b7a
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=hexagon SHELL=/bin/bash drivers/nvme/host/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>
All warnings (new ones prefixed by >>):
>> drivers/nvme/host/tcp.c:678:7: warning: variable 'map' is uninitialized when used here [-Wuninitialized]
if (map[i].fes == pdu->fes) {
^~~
drivers/nvme/host/tcp.c:672:28: note: initialize the variable 'map' to silence this warning
struct fes_status_map *map;
^
= NULL
drivers/nvme/host/tcp.c:1351:35: warning: format specifies type 'unsigned long' but the argument has type 'size_t' (aka 'unsigned int') [-Wformat]
nvme_tcp_queue_id(queue), ret, iov.iov_len);
^~~~~~~~~~~
include/linux/printk.h:574:26: note: expanded from macro 'pr_debug'
dynamic_pr_debug(fmt, ##__VA_ARGS__)
~~~ ^~~~~~~~~~~
include/linux/dynamic_debug.h:163:22: note: expanded from macro 'dynamic_pr_debug'
pr_fmt(fmt), ##__VA_ARGS__)
~~~ ^~~~~~~~~~~
include/linux/dynamic_debug.h:152:56: note: expanded from macro '_dynamic_func_call'
__dynamic_func_call(__UNIQUE_ID(ddebug), fmt, func, ##__VA_ARGS__)
^~~~~~~~~~~
include/linux/dynamic_debug.h:134:15: note: expanded from macro '__dynamic_func_call'
func(&id, ##__VA_ARGS__); \
^~~~~~~~~~~
drivers/nvme/host/tcp.c:1385:7: warning: format specifies type 'unsigned long' but the argument has type 'size_t' (aka 'unsigned int') [-Wformat]
iov.iov_len);
^~~~~~~~~~~
include/linux/printk.h:574:26: note: expanded from macro 'pr_debug'
dynamic_pr_debug(fmt, ##__VA_ARGS__)
~~~ ^~~~~~~~~~~
include/linux/dynamic_debug.h:163:22: note: expanded from macro 'dynamic_pr_debug'
pr_fmt(fmt), ##__VA_ARGS__)
~~~ ^~~~~~~~~~~
include/linux/dynamic_debug.h:152:56: note: expanded from macro '_dynamic_func_call'
__dynamic_func_call(__UNIQUE_ID(ddebug), fmt, func, ##__VA_ARGS__)
^~~~~~~~~~~
include/linux/dynamic_debug.h:134:15: note: expanded from macro '__dynamic_func_call'
func(&id, ##__VA_ARGS__); \
^~~~~~~~~~~
drivers/nvme/host/tcp.c:1400:35: warning: format specifies type 'unsigned long' but the argument has type 'size_t' (aka 'unsigned int') [-Wformat]
nvme_tcp_queue_id(queue), ret, iov.iov_len);
^~~~~~~~~~~
include/linux/printk.h:574:26: note: expanded from macro 'pr_debug'
dynamic_pr_debug(fmt, ##__VA_ARGS__)
~~~ ^~~~~~~~~~~
include/linux/dynamic_debug.h:163:22: note: expanded from macro 'dynamic_pr_debug'
pr_fmt(fmt), ##__VA_ARGS__)
~~~ ^~~~~~~~~~~
include/linux/dynamic_debug.h:152:56: note: expanded from macro '_dynamic_func_call'
__dynamic_func_call(__UNIQUE_ID(ddebug), fmt, func, ##__VA_ARGS__)
^~~~~~~~~~~
include/linux/dynamic_debug.h:134:15: note: expanded from macro '__dynamic_func_call'
func(&id, ##__VA_ARGS__); \
^~~~~~~~~~~
4 warnings generated.
vim +/map +678 drivers/nvme/host/tcp.c
667
668 static int nvme_tcp_handle_c2h_term(struct nvme_tcp_queue *queue,
669 struct nvme_tcp_term_pdu *pdu)
670 {
671 struct nvme_tcp_hdr *ref_pdu;
672 struct fes_status_map *map;
673 const char *fes_desc = NULL;
674 int i;
675 u32 pdu_offset;
676
677 for (i = 0; i < ARRAY_SIZE(fes_status); i++) {
> 678 if (map[i].fes == pdu->fes) {
679 fes_desc = map[i].desc;
680 break;
681 }
682 }
683 if (!fes_desc)
684 fes_desc = "unknown fatal error status";
685
686 if (pdu->hdr.plen > sizeof(struct nvme_tcp_term_pdu))
687 ref_pdu = (struct nvme_tcp_hdr *)((u8 *)pdu + 1);
688
689 if (pdu->fes == NVME_TCP_FES_INVALID_PDU_HDR ||
690 pdu->fes == NVME_TCP_FES_HDR_DIGEST_ERR ||
691 pdu->fes == NVME_TCP_FES_UNSUPPORTED_PARAM) {
692 pdu_offset = le32_to_cpu(pdu->fei);
693
694 dev_err(queue->ctrl->ctrl.device,
695 "queue %d c2h term, %s, pdu type %u offset %u\n",
696 nvme_tcp_queue_id(queue), fes_desc, ref_pdu->type, pdu_offset);
697 } else
698 dev_err(queue->ctrl->ctrl.device,
699 "queue %d c2h term, %s, pdu type %u\n",
700 nvme_tcp_queue_id(queue), fes_desc, ref_pdu->type);
701
702 return -ECONNRESET;
703 }
704
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
Powered by blists - more mailing lists