linux-kernel - [PATCH -next?] x86: PCI: asm/pci

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 26 Feb 2022 13:37:03 -0800
From:   Randy Dunlap <rdunlap@...radead.org>
To:     linux-kernel@...r.kernel.org
Cc:     Randy Dunlap <rdunlap@...radead.org>,
        Mark Brown <broonie@...nel.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>,
        Dave Hansen <dave.hansen@...ux.intel.com>, x86@...nel.org,
        linux-pci@...r.kernel.org
Subject: [PATCH -next?] x86: PCI: asm/pci_x86.h needs more #includes

<asm/pci_x86.h> uses EINVAL, __init, and raw_spinlock_t, so it
should #include the appropriate files to prevent build errors.

../arch/x86/include/asm/pci_x86.h:150:10: error: ‘EINVAL’ undeclared (first use in this function)
  return -EINVAL;

../arch/x86/include/asm/pci_x86.h:105:8: error: unknown type name ‘raw_spinlock_t’
 extern raw_spinlock_t pci_config_lock;

../arch/x86/include/asm/pci_x86.h:141:20: error: expected ‘=’, ‘,’, ‘;’, ‘asm’ or ‘__attribute__’ before ‘dmi_check_pciprobe’
 extern void __init dmi_check_pciprobe(void);

Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
Cc: Mark Brown <broonie@...nel.org>
Cc: Thomas Gleixner <tglx@...utronix.de>
Cc: Ingo Molnar <mingo@...hat.com>
Cc: Borislav Petkov <bp@...en8.de>
Cc: Dave Hansen <dave.hansen@...ux.intel.com>
Cc: x86@...nel.org
Cc: linux-pci@...r.kernel.org
---
Without this patch, I am seeing *many* build errors in
linux-next-20220225.

I don't know why this showed up in linux-next-20220225 all of a
sudden.

 arch/x86/include/asm/pci_x86.h |    3 +++
 1 file changed, 3 insertions(+)

--- linux-next-20220225.orig/arch/x86/include/asm/pci_x86.h
+++ linux-next-20220225/arch/x86/include/asm/pci_x86.h
@@ -5,7 +5,10 @@
  *	(c) 1999 Martin Mares <mj@....cz>
  */
 
+#include <linux/errno.h>
+#include <linux/init.h>
 #include <linux/ioport.h>
+#include <linux/spinlock.h>
 
 #undef DEBUG