linux-kernel - Re: [PATCH v6 1/3] dt-bindings: iio: amplifiers: add ada4250 doc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220227121035.07a922a8@jic23-huawei>
Date:   Sun, 27 Feb 2022 12:10:35 +0000
From:   Jonathan Cameron <jic23@...nel.org>
To:     Rob Herring <robh@...nel.org>
Cc:     Antoniu Miclaus <antoniu.miclaus@...log.com>,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-iio@...r.kernel.org, robh+dt@...nel.org,
        Krzysztof Kozlowski <krzysztof.kozlowski@...onical.com>
Subject: Re: [PATCH v6 1/3] dt-bindings: iio: amplifiers: add ada4250 doc

On Thu, 24 Feb 2022 10:31:17 -0600
Rob Herring <robh@...nel.org> wrote:

> On Wed, 23 Feb 2022 14:01:10 +0200, Antoniu Miclaus wrote:
> > Add device tree bindings for the ADA4250 driver.
> > 
> > Signed-off-by: Antoniu Miclaus <antoniu.miclaus@...log.com>
> > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@...onical.com>
> > ---
> > changes in v6:
> >  - add space before `{` in the amplifier node example
> >  .../bindings/iio/amplifiers/adi,ada4250.yaml  | 50 +++++++++++++++++++
> >  1 file changed, 50 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/iio/amplifiers/adi,ada4250.yaml
> >   
> 
> Reviewed-by: Rob Herring <robh@...nel.org>

Series applied to the togreg branch of iio.git and pushed out as testing for
0-day to take a quick look before I go making a mess of linux-next.

One side comment though - when there are lots of revisions in a short timescale
and people haven't had time to get back to the intermediate ones, it is particularly
helpful to give a multi version change log.

i.e. tell us what happened in at least the last couple of revisions to save
on having to go find the earlier threads to find out what changed in v5 and v4!

Also, I always prefer a cover letter for a series even if brief. It give somewhere
to reply to if there are discussions covering multiple patches, or if someone wants
to give a tag for the whole series that I can trivially pick up with b4.
Obviously no point for single patch series though!
I don't normally moan about this, but I was moaning anyway so why not get
everything off my chest! :)

Thanks,

Jonathan