linux-kernel - Re: [PATCH V6 09/22] LoongArch: Add boot and setup routines

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMj1kXHWRZcjF9H2jZ+p-HNuXyPs-=9B8WiYLsrDJGpipgKo_w@mail.gmail.com>
Date:   Sun, 27 Feb 2022 15:14:30 +0100
From:   Ard Biesheuvel <ardb@...nel.org>
To:     Huacai Chen <chenhuacai@...ngson.cn>,
        "Rafael J. Wysocki" <rafael@...nel.org>,
        Len Brown <lenb@...nel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     Arnd Bergmann <arnd@...db.de>, Andy Lutomirski <luto@...nel.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Peter Zijlstra <peterz@...radead.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        David Airlie <airlied@...ux.ie>,
        Jonathan Corbet <corbet@....net>,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        linux-arch <linux-arch@...r.kernel.org>,
        Linux Doc Mailing List <linux-doc@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Xuefeng Li <lixuefeng@...ngson.cn>,
        Yanteng Si <siyanteng@...ngson.cn>,
        Huacai Chen <chenhuacai@...il.com>,
        Jiaxun Yang <jiaxun.yang@...goat.com>,
        linux-efi <linux-efi@...r.kernel.org>
Subject: Re: [PATCH V6 09/22] LoongArch: Add boot and setup routines

(add Greg and ACPI maintainers)

On Sat, 26 Feb 2022 at 12:11, Huacai Chen <chenhuacai@...ngson.cn> wrote:
>
> This patch adds basic boot, setup and reset routines for LoongArch.
> LoongArch uses UEFI-based firmware. The firmware uses ACPI and DMI/
> SMBIOS to pass configuration information to the Linux kernel (in elf
> format).
>
> Now the boot information passed to kernel is like this:
> 1, kernel get 3 register values (a0, a1 and a2) from bootloader.
> 2, a0 is "argc", a1 is "argv", so "kernel cmdline" comes from a0/a1.
> 3, a2 is "environ", which is a pointer to "struct bootparamsinterface".
> 4, "struct bootparamsinterface" include a "systemtable" pointer, whose
>    type is "efi_system_table_t". Most configuration information, include
>    ACPI tables and SMBIOS tables, come from here.
>
> Cc: Ard Biesheuvel <ardb@...nel.org>
> Cc: linux-efi@...r.kernel.org
> Signed-off-by: Huacai Chen <chenhuacai@...ngson.cn>
> ---
>  arch/loongarch/include/asm/acenv.h      |  17 +
>  arch/loongarch/include/asm/acpi.h       |  38 ++
>  arch/loongarch/include/asm/boot_param.h |  97 +++++
>  arch/loongarch/include/asm/bootinfo.h   |  33 ++
>  arch/loongarch/include/asm/dmi.h        |  24 ++
>  arch/loongarch/include/asm/efi.h        |  33 ++
>  arch/loongarch/include/asm/fw.h         |  18 +
>  arch/loongarch/include/asm/reboot.h     |  10 +
>  arch/loongarch/include/asm/setup.h      |  21 +
>  arch/loongarch/kernel/acpi.c            | 338 ++++++++++++++++
>  arch/loongarch/kernel/cacheinfo.c       | 122 ++++++
>  arch/loongarch/kernel/cmdline.c         |  31 ++
>  arch/loongarch/kernel/cpu-probe.c       | 305 +++++++++++++++
>  arch/loongarch/kernel/efi.c             | 208 ++++++++++
>  arch/loongarch/kernel/env.c             | 176 +++++++++
>  arch/loongarch/kernel/head.S            |  72 ++++
>  arch/loongarch/kernel/mem.c             |  89 +++++
>  arch/loongarch/kernel/reset.c           |  90 +++++
>  arch/loongarch/kernel/setup.c           | 495 ++++++++++++++++++++++++
>  arch/loongarch/kernel/time.c            | 220 +++++++++++
>  arch/loongarch/kernel/topology.c        |  13 +
>  21 files changed, 2450 insertions(+)

As I pointed out in response to an earlier revision of this code, I
don't think we should merge this until we decide on some ground rules
regarding the support level of this architecture in the UEFI and ACPI
subsystems.

The problem is that loongarch does not exist in the ACPI or UEFI
specifications at all, and as I understand it, the firmware
implementations themselves do not implement UEFI or ACPI entirely,
they simply present data structures in memory that look similar enough
for the Linux UEFI and ACPI code to boot the OS.

As the UEFI subsystem maintainer, I am concerned that future changes
to the UEFI subsystem that are rooted in the the UEFI specification as
it evolves may trigger unanticipated results on this architecture, and
I imagine the ACPI maintainers may have similar concerns.

So what can we do about this? Do we merge this code, but as a second
class citizen in terms of UEFI/ACPI subsystem support, i.e., you are
welcome to use it, but if something breaks, the UEFI/ACPI maintainers
are not on the hook to see to it that it gets fixed? I don't think
this is a great solution, but I'm not sure if there are alternatives
that are any better.

Thoughts, please?

-- 
Ard.