linux-kernel - Re: [PATCH] mm/vmalloc.c: fix a comment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <572369c5-85e4-75af-85f4-d150c25e75fd@infradead.org>
Date:   Sun, 27 Feb 2022 08:29:36 -0800
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Yixuan Cao <caoyixuan2019@...il.szu.edu.cn>,
        akpm@...ux-foundation.org
Cc:     linux-mm@...ck.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mm/vmalloc.c: fix a comment



On 2/27/22 00:45, Yixuan Cao wrote:
> Dear Sir/Madam,
> 
> The sentence
> "but the mempolcy want to alloc memory by interleaving"
> should be rephrased with
> "but the mempolicy wants to alloc memory by interleaving"
> where "mempolicy" is a struct name.
> 
> Thanks and best regards,
> Yixuan Cao
> 
> Signed-off-by: Yixuan Cao <caoyixuan2019@...il.szu.edu.cn>
> ---
>  mm/vmalloc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/mm/vmalloc.c b/mm/vmalloc.c
> index b454cf1a261f..89d48d8eb20c 100644
> --- a/mm/vmalloc.c
> +++ b/mm/vmalloc.c
> @@ -2905,7 +2905,7 @@ vm_area_alloc_pages(gfp_t gfp, int nid,
>  			/* memory allocation should consider mempolicy, we can't
>  			 * wrongly use nearest node when nid == NUMA_NO_NODE,
>  			 * otherwise memory may be allocated in only one node,
> -			 * but mempolcy want to alloc memory by interleaving.
> +			 * but mempolicy want to alloc memory by interleaving.

s/want/wants/
as in your commentary above.

>  			 */
>  			if (IS_ENABLED(CONFIG_NUMA) && nid == NUMA_NO_NODE)
>  				nr = alloc_pages_bulk_array_mempolicy(bulk_gfp,

thanks.
-- 
~Randy