linux-kernel - [BISECTED] input: ads7846: touchscreen broken on Nokia 770

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220227185038.GA3016@darkstar.musicnaut.iki.fi>
Date:   Sun, 27 Feb 2022 20:50:38 +0200
From:   Aaro Koskinen <aaro.koskinen@....fi>
To:     Dmitry Torokhov <dmitry.torokhov@...il.com>,
        Oleksij Rempel <o.rempel@...gutronix.de>,
        linux-input@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: [BISECTED] input: ads7846: touchscreen broken on Nokia 770

Hi,

I noticed touchscreen does not work anymore on Nokia 770:

[    2.131011] ads7846 spi2.0: touchscreen, irq 175
[    2.200622] input: ADS7846 Touchscreen as /devices/platform/omap_uwire/spi_master/spi2/spi2.0/input/input0

(then touching the screen:)

[   52.316894] ads7846 spi2.0: spi_sync --> -22
[   52.336944] ads7846 spi2.0: spi_sync --> -22

bisected this to:

commit 9c9509717b53e701469493a8d87ed42c7d782502
Author: Oleksij Rempel <o.rempel@...gutronix.de>
Date:   Wed Nov 11 16:39:05 2020 -0800

    Input: ads7846 - convert to full duplex

It seems it's failing on SPI_CONTROLLER_HALF_DUPLEX check in
__spi_validate(). The controller used on this board (spi-omap-uwire)
sets that flag. How ads7846 is now supposed to work in that case after
this conversion?

A.