linux-kernel - Re: [PATCH 1/2] dt-bindings: phy: qcom,qmp: Mark '#clock-cells' as a 'optional' property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sun, 27 Feb 2022 09:49:31 +0530
From:   Bhupesh Sharma <bhupesh.sharma@...aro.org>
To:     Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
Cc:     linux-arm-msm@...r.kernel.org, bhupesh.linux@...il.com,
        agross@...nel.org, linux-kernel@...r.kernel.org,
        devicetree@...r.kernel.org, linux-phy@...ts.infradead.org,
        robh+dt@...nel.org, Bjorn Andersson <bjorn.andersson@...aro.org>,
        Vinod Koul <vkoul@...nel.org>
Subject: Re: [PATCH 1/2] dt-bindings: phy: qcom,qmp: Mark '#clock-cells' as a
 'optional' property

On Sun, 27 Feb 2022 at 05:08, Dmitry Baryshkov
<dmitry.baryshkov@...aro.org> wrote:
>
> On 25/02/2022 12:16, Bhupesh Sharma wrote:
> > Hi Dmitry,
> >
> > Thanks for your review comments.
> >
> > On Thu, 24 Feb 2022 at 20:22, Dmitry Baryshkov
> > <dmitry.baryshkov@...aro.org> wrote:
> >>
> >> On Thu, 24 Feb 2022 at 15:33, Bhupesh Sharma <bhupesh.sharma@...aro.org> wrote:
> >>>
> >>> Since '#clock-cells' is not a required property for several
> >>> QCoM boards supporting qmp-phy(s) (for e.g. sm8150, sm8250 or sm8350 SoC
> >>> based boards), mark it as an optional property instead.
> >>
> >> I believe the description is not correct. the clock-cells should not
> >> be used at all, so it should be removed from the root node.
> >
> > Hmm.. 'clock-cells' is still used for describing qmp phy pcie nodes for certain
> > devices like 'msm8996.dtsi'. I am not sure if removing it would impact existing
> > dts files. But let me try cleaning them up in v2.
>
> Checked. Unless I'm mistaken, msm8996.dtsi doesn't use #clock-cells in
> root QMP PHY nodes.

Indeed. I meant that we made some cleanups already via
82d61e19fccb ("arm64: dts: qcom: msm8996: Move '#clock-cells' to QMP
PHY child node"),
but it seems a few dts still need to be cleaned up to move the
'#clock-cells' to QMP PHY child node instead of the root node.

I will send a fixed version in v2 :)

Regards,
Bhupesh