lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-Id: <20220227093434.2889464-6-jhubbard@nvidia.com> Date: Sun, 27 Feb 2022 01:34:33 -0800 From: jhubbard.send.patches@...il.com To: Jens Axboe <axboe@...nel.dk>, Jan Kara <jack@...e.cz>, Christoph Hellwig <hch@...radead.org>, Dave Chinner <dchinner@...hat.com>, "Darrick J . Wong" <djwong@...nel.org>, Theodore Ts'o <tytso@....edu>, Alexander Viro <viro@...iv.linux.org.uk>, Miklos Szeredi <miklos@...redi.hu>, Andrew Morton <akpm@...ux-foundation.org>, Chaitanya Kulkarni <kch@...dia.com> Cc: linux-block@...r.kernel.org, linux-fsdevel@...r.kernel.org, linux-xfs@...r.kernel.org, linux-mm@...ck.org, LKML <linux-kernel@...r.kernel.org>, John Hubbard <jhubbard@...dia.com> Subject: [PATCH 5/6] NFS: direct-io: convert to FOLL_PIN pages From: John Hubbard <jhubbard@...dia.com> Convert nfs-direct to use pin_user_pages_fast(), and unpin_user_pages(), in place of get_user_pages_fast() and put_page(). Signed-off-by: John Hubbard <jhubbard@...dia.com> --- fs/nfs/direct.c | 15 ++++----------- 1 file changed, 4 insertions(+), 11 deletions(-) diff --git a/fs/nfs/direct.c b/fs/nfs/direct.c index eabfdab543c8..42111a75c0f7 100644 --- a/fs/nfs/direct.c +++ b/fs/nfs/direct.c @@ -177,13 +177,6 @@ ssize_t nfs_direct_IO(struct kiocb *iocb, struct iov_iter *iter) return nfs_file_direct_write(iocb, iter); } -static void nfs_direct_release_pages(struct page **pages, unsigned int npages) -{ - unsigned int i; - for (i = 0; i < npages; i++) - put_page(pages[i]); -} - void nfs_init_cinfo_from_dreq(struct nfs_commit_info *cinfo, struct nfs_direct_req *dreq) { @@ -367,7 +360,7 @@ static ssize_t nfs_direct_read_schedule_iovec(struct nfs_direct_req *dreq, size_t pgbase; unsigned npages, i; - result = iov_iter_get_pages_alloc(iter, &pagevec, + result = iov_iter_pin_pages_alloc(iter, &pagevec, rsize, &pgbase); if (result < 0) break; @@ -398,7 +391,7 @@ static ssize_t nfs_direct_read_schedule_iovec(struct nfs_direct_req *dreq, pos += req_len; dreq->bytes_left -= req_len; } - nfs_direct_release_pages(pagevec, npages); + unpin_user_pages(pagevec, npages); kvfree(pagevec); if (result < 0) break; @@ -811,7 +804,7 @@ static ssize_t nfs_direct_write_schedule_iovec(struct nfs_direct_req *dreq, size_t pgbase; unsigned npages, i; - result = iov_iter_get_pages_alloc(iter, &pagevec, + result = iov_iter_pin_pages_alloc(iter, &pagevec, wsize, &pgbase); if (result < 0) break; @@ -850,7 +843,7 @@ static ssize_t nfs_direct_write_schedule_iovec(struct nfs_direct_req *dreq, pos += req_len; dreq->bytes_left -= req_len; } - nfs_direct_release_pages(pagevec, npages); + unpin_user_pages(pagevec, npages); kvfree(pagevec); if (result < 0) break; -- 2.35.1
Powered by blists - more mailing lists