linux-kernel - Re: [PATCH] habanalabs: Add check for pci_enable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAFCwf13dFDbkRer6uESKdWjpdt1QbMvDVV0989e1+FHXais_6Q@mail.gmail.com>
Date:   Sun, 27 Feb 2022 11:41:36 +0200
From:   Oded Gabbay <ogabbay@...nel.org>
To:     Jiasheng Jiang <jiasheng@...as.ac.cn>
Cc:     Arnd Bergmann <arnd@...db.de>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Yuri Nudelman <ynudelman@...ana.ai>,
        Ofir Bitton <obitton@...ana.ai>,
        "Linux-Kernel@...r. Kernel. Org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] habanalabs: Add check for pci_enable_device

On Thu, Feb 24, 2022 at 8:58 AM Jiasheng Jiang <jiasheng@...as.ac.cn> wrote:
>
> As the potential failure of the pci_enable_device(),
> it should be better to check the return value and return
> error if fails.
>
> Fixes: 70b2f993ea4a ("habanalabs: create common folder")
> Signed-off-by: Jiasheng Jiang <jiasheng@...as.ac.cn>
> ---
>  drivers/misc/habanalabs/common/debugfs.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/misc/habanalabs/common/debugfs.c b/drivers/misc/habanalabs/common/debugfs.c
> index fc084ee5106e..09001fd9db85 100644
> --- a/drivers/misc/habanalabs/common/debugfs.c
> +++ b/drivers/misc/habanalabs/common/debugfs.c
> @@ -890,6 +890,8 @@ static ssize_t hl_set_power_state(struct file *f, const char __user *buf,
>                 pci_set_power_state(hdev->pdev, PCI_D0);
>                 pci_restore_state(hdev->pdev);
>                 rc = pci_enable_device(hdev->pdev);
> +               if (rc < 0)
> +                       return rc;
>         } else if (value == 2) {
>                 pci_save_state(hdev->pdev);
>                 pci_disable_device(hdev->pdev);
> --
> 2.25.1
>
This patch is:
Reviewed-by: Oded Gabbay <ogabbay@...nel.org>
Applied to -next.
Thanks,
Oded